All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: "Adam J. Richter" <adam@yggdrasil.com>,
	James.Bottomley@HansenPartnership.com, hch@lst.de,
	linux-scsi@vger.kernel.org
Subject: Re: Patch?: linux-2.5.45/drivers/scsi/hosts.[ch] - Eliminate scsi_host_tmpl_list
Date: Sun, 10 Nov 2002 04:13:46 +0100	[thread overview]
Message-ID: <20021110041346.A31976@lst.de> (raw)
In-Reply-To: <20021107120045.A14136@eng2.beaverton.ibm.com>; from patmans@us.ibm.com on Thu, Nov 07, 2002 at 12:00:45PM -0800

On Thu, Nov 07, 2002 at 12:00:45PM -0800, Patrick Mansfield wrote:
> I fixed that, and added code in scsi_alloc_host_num to reuse empty
> slots (if no match on scsihosts or scsihosts is empty).
> 
> But, there is no way to match the previous functionallity without having
> a host name list.
> 
> That is before the patch we can do this:
> 
> 	insmod foo; insmod bar
> 
> And foo gets scsi4, bar scsi5. And then:
> 
> 	rmmod foo; rmmod bar
> 	insmod bar; insmod foo
> 
> And foo should still be scsi4, bar scsi5.
> 
> Without the host name list, the best we can do is have
> foo become scsi5, and bar scsi4.

Well, this is a behaviour change, but IMHO the old behaviour is bad.
> 
> I think we should forget about this patch for now, and at some time in
> the future after we have some device naming persistence drop the name
> list and scsihosts option.

I'd really like to get your fixed version of the patch in, no other
subsystem has similar strange hacks and I don't think the cruft is worth
that little gain.  People unsing that feature (are there any?  if yes
please explain what it buys you) might have a different opinion..


  reply	other threads:[~2002-11-10  3:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-06  0:51 Patch?: linux-2.5.45/drivers/scsi/hosts.[ch] - Eliminate scsi_host_tmpl_list Adam J. Richter
2002-11-07 20:00 ` Patrick Mansfield
2002-11-10  3:13   ` Christoph Hellwig [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-11-10  5:40 Adam J. Richter
2002-11-10  5:37 Adam J. Richter
2002-11-10 17:46 ` Patrick Mansfield
2002-11-05 12:20 Adam J. Richter
2002-11-05 22:58 ` Christoph Hellwig
2002-11-05 23:54 ` Christoph Hellwig
2002-11-07  1:13   ` Patrick Mansfield
2002-11-04 16:22 Adam J. Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021110041346.A31976@lst.de \
    --to=hch@lst.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=adam@yggdrasil.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=patmans@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.