From: Tom Rini <trini@kernel.crashing.org>
To: Peter Samuelson <peter@cadcamlab.org>
Cc: kbuild-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>
Subject: Re: [PATCH] Have split-include take another argument
Date: Tue, 12 Nov 2002 08:09:32 -0700 [thread overview]
Message-ID: <20021112150932.GE658@opus.bloom.county> (raw)
In-Reply-To: <20021111233710.GR4182@cadcamlab.org>
On Mon, Nov 11, 2002 at 05:37:10PM -0600, Peter Samuelson wrote:
> [Tom Rini]
> > First, does anyone see any problems with the patch itself?
>
> Well,
>
> > - str_config += sizeof("CONFIG_") - 1;
> > + str_config += strlen(str_split_token);
>
> it does seem a bit inefficient to call strlen() for every single line
> of every single source file. Perhaps today's compilers know that
> strlen() is invariant and has no side effects, but I vote you go ahead
> and optimise it explicitly.
Sounds good, thanks.
--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2002-11-12 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-11 17:06 [PATCH] Have split-include take another argument Tom Rini
2002-11-11 23:37 ` Peter Samuelson
2002-11-12 15:09 ` Tom Rini [this message]
2002-11-14 21:01 ` Kai Germaschewski
2002-11-14 23:17 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021112150932.GE658@opus.bloom.county \
--to=trini@kernel.crashing.org \
--cc=kai@tp1.ruhr-uni-bochum.de \
--cc=kbuild-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@cadcamlab.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.