From: Brad Heilbrun <bheilbrun@paypal.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [2.5-bk] Module loader compile bug
Date: Tue, 12 Nov 2002 18:13:07 -0800 [thread overview]
Message-ID: <20021113021307.GA8238@paypal.com> (raw)
In-Reply-To: <20021112172423.818182C2A0@lists.samba.org>
On Wed, Nov 13, 2002 at 04:23:26AM +1100, Rusty Russell wrote:
> In message <20021112050319.GA3651@paypal.com> you write:
> > I realize you're still working on this, but current bk is broken if
> > you turn off module unload support. In include/linux/module.h we get:
> >
> > #else /*!CONFIG_MODULE_UNLOAD*/
> > <snip>
> > #define symbol_put_addr(p) do { } while(0)
> >
> > #endif /* CONFIG_MODULE_UNLOAD */
> >
> > Which upsets this line in kernel/module.c
> >
> > void symbol_put_addr(void *addr)
> >
> > After the preprocessor gets a hold of it all, gcc doesn't know what to
> > make of "void do { } while(0)".
>
> Yep, symbol_put_addr() in module.c should be moved under __symbol_put.
>
> Patch is fairly trivial, does this work for you?
Yes, thanks.
--
Brad Heilbrun
prev parent reply other threads:[~2002-11-13 2:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20021112050319.GA3651@paypal.com>
2002-11-12 17:23 ` [2.5-bk] Module loader compile bug Rusty Russell
2002-11-12 17:48 ` Paul Larson
2002-11-13 2:13 ` Brad Heilbrun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021113021307.GA8238@paypal.com \
--to=bheilbrun@paypal.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.