From: Nathan Scott <nathans@sgi.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Steve Lord <lord@sgi.com>, Anders Gustafsson <andersg@0x63.nu>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.5-bk AT_GID clash
Date: Wed, 13 Nov 2002 18:34:11 +1100 [thread overview]
Message-ID: <20021113073411.GF513@frodo.melbourne.sgi.com> (raw)
In-Reply-To: <20021113071630.190EC2C077@lists.samba.org>
On Wed, Nov 13, 2002 at 05:07:03AM +1100, Rusty Russell wrote:
> In message <1037122398.27014.43.camel@jen.americas.sgi.com> you write:
> >
> > But does everyone who wants to implement a module need to be exposed
> > to all the details of the elf header?
>
> Well, linux/module.h -> asm/module.h -> linux/elf.h. Although if you
> use #define instead of typedef you can break the last link. Feel free
> to send a patch to split it into moduleload.h or something, but I
> think it'll look tiny.
>
> But IMHO the nameclash needs to be fixed *anyway*, not hacked around,
> or someone else will run over it one day. AFAICT, changing
> fs/binfmt_elf.c and elf.h to AT_RGID is the simplest. Both should be
> mildly chastised for using a prefix like AT_ publically.
FWIW, we changed XFS earlier today - it will go to Linus in the
next batch of XFS mods. We're now using an XFS_AT_* convention
instead.
cheers.
--
Nathan
next prev parent reply other threads:[~2002-11-13 7:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-12 1:18 2.5-bk AT_GID clash Anders Gustafsson
2002-11-12 17:16 ` Rusty Russell
2002-11-12 17:33 ` Steve Lord
2002-11-12 18:07 ` Rusty Russell
2002-11-13 7:34 ` Nathan Scott [this message]
2002-11-13 11:17 ` linux/elf.h vs linux/module.h [was: 2.5-bk AT_GID clash] Anders Gustafsson
2002-11-14 1:53 ` Rusty Russell
2002-11-13 22:37 ` 2.5-bk AT_GID clash Paul Mackerras
2002-11-12 18:07 ` Christoph Hellwig
2002-11-12 22:50 ` Anders Gustafsson
2002-11-14 6:44 ` Rusty Russell
2002-11-14 13:26 ` Anders Gustafsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021113073411.GF513@frodo.melbourne.sgi.com \
--to=nathans@sgi.com \
--cc=andersg@0x63.nu \
--cc=linux-kernel@vger.kernel.org \
--cc=lord@sgi.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.