Re: [PATCH] save inverted MAC match

[Michael Schwendt <rh0209ms@arcor.de>]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 6 Nov 2002 17:21:19 +0100, Michael Schwendt wrote:

> The "mac" userspace extension contains a minor bug for both IPv4 and
> IPv6. Upon printing/saving a rule which matches inverted MAC
> addresses, a space character is missing between the '!' prefix and
> the MAC address. Hence iptables-restore fails to parse the output of
> iptables-save. iptables 1.2.5, 1.2.6a, 1.2.7a and CVS are affected.
> 
> Steps to reproduce:
> 
>   iptables -N test
>   iptables -I test -m mac --mac-source ! 01:02:03:04:05:06
>   iptables-save | iptables-restore
> 
> Further reference:
> 
>   https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=77337

In CVS, only the IPv4 code has been fixed (somehow I've missed v1.8
of libipt_mac.c - don't know why).

The IPv6 code still contains the same bug (in CVS libip6t_mac.c
v1.5). Please don't forget to apply the patch. 

- -- 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)

iD8DBQE91Ccc0iMVcrivHFQRArM7AJ4x4n0YdhEYD45Bg3FYNKHgfky+9gCghax1
Thx88ZNFK4KpS2kSQXXlCgg=
=l7w/
-----END PGP SIGNATURE-----

[-- Attachment #2: iptables-1.2.7a-invertmac.patch --]
[-- Type: application/octet-stream, Size: 577 bytes --]

Red Hat Linux bug #77337: Add missing space between '!' and MAC
address upon printing/saving rules.

diff -Naur iptables-1.2.7a-orig/extensions/libip6t_mac.c iptables-1.2.7a/extensions/libip6t_mac.c
--- iptables-1.2.7a-orig/extensions/libip6t_mac.c	Wed May 29 15:08:16 2002
+++ iptables-1.2.7a/extensions/libip6t_mac.c	Wed Nov  6 16:50:17 2002
@@ -90,7 +90,7 @@
 {
 	unsigned int i;
 
-	printf("%s%02X", invert ? "!" : "", macaddress[0]);
+	printf("%s%02X", invert ? "! " : "", macaddress[0]);
 	for (i = 1; i < ETH_ALEN; i++)
 		printf(":%02X", macaddress[i]);
 	printf(" ");