All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J.E.J. Bottomley" <James.Bottomley@steeleye.com>
To: Arnd Bergmann <ibm.com@arndb.de>
Cc: "J.E.J. Bottomley" <James.Bottomley@SteelEye.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Linux Scsi <linux-scsi@vger.kernel.org>,
	Mike Anderson <andmike@us.ibm.com>
Subject: Re: [RFC][PATCH] move dma_mask into struct device
Date: Sat, 16 Nov 2002 10:33:44 -0500	[thread overview]
Message-ID: <200211161533.gAGFXiF02733@localhost.localdomain> (raw)
In-Reply-To: Message from Arnd Bergmann <arndb@de.ibm.com> of "Sat, 16 Nov 2002 18:23:48 +0100." <200211161823.48018.arndb@de.ibm.com>

arndb@de.ibm.com said:
> That does not sound like the right way to me. If you need to have the
> dma_mask for the Scsi_Host, you should store it in Scsi_Host itself. A
> struct device must never know about obscure architecture specific
> stuff like dma.

The SCSI host itself has no need of a DMA mask.  What we need the mask for is 
to set up the bounce limits for the block queue, we don't actually ever use it 
again.  Unfortunately, dma_mask isn't architecture specific, its a universal 
property of the block queues used to determine when to bounce memory regions.

The dma_mask is a property of the connection of the Scsi_Host to the machine 
bus, not of the Scsi_Host itself, so it does properly belong in the generic 
device which is used to reflect machine bus attachments.

Think of it this way: we have two struct device's per SCSI host: one for the 
actual HBA card or bus attachment, which contains all of the bus specific 
pieces, and one for the host itself reflecting the fact that it is a bridge 
from the machine bus to the scsi bus.

James




  reply	other threads:[~2002-11-16 15:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <arndb@de.ibm.com>
2002-11-16 17:23 ` [RFC][PATCH] move dma_mask into struct device Arnd Bergmann
2002-11-16 15:33   ` J.E.J. Bottomley [this message]
2002-11-16 18:26     ` Arnd Bergmann
2002-11-16 17:01       ` J.E.J. Bottomley
2002-11-16 19:56         ` Arnd Bergmann
2002-11-16 19:56           ` Arnd Bergmann
2002-11-16 18:12           ` J.E.J. Bottomley
2002-11-16 20:46             ` Arnd Bergmann
2002-11-15 20:34 J.E.J. Bottomley
2002-11-16  0:19 ` Mike Anderson
2002-11-16 14:48   ` J.E.J. Bottomley
2002-11-16 20:33 ` Patrick Mansfield
2002-11-17 15:07   ` J.E.J. Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200211161533.gAGFXiF02733@localhost.localdomain \
    --to=james.bottomley@steeleye.com \
    --cc=andmike@us.ibm.com \
    --cc=ibm.com@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.