From: John Levon <levon@movementarian.org>
To: Corey Minyard <cminyard@mvista.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
"'Zwane Mwaikambo'" <zwane@holomorphy.com>,
linux-kernel@vger.kernel.org
Subject: Re: NMI handling rework for x86
Date: Sun, 17 Nov 2002 02:00:17 +0000 [thread overview]
Message-ID: <20021117020017.GA96715@compsoc.man.ac.uk> (raw)
In-Reply-To: <3DD5444E.9070808@mvista.com>
On Fri, Nov 15, 2002 at 01:00:30PM -0600, Corey Minyard wrote:
> I have attached another patch, this one fixes my stupid bug in
> dummy_watchdog_reset and also adds code to the NMI watchdog to not
> handle the NMI if it has already been handled. Again, you must do a "cd
> arch/i386/kernel; mv nmi.c nmi_watchdog.c" before applying this patch.
I have tested this patch running oprofile on a dual box at 150,000
ints/sec and more, with nmi_watchdog=0,1,2, and couldn't reproduce any
problems.
One thing: since we have the unnatural relationship between the watchdog
and oprofile, I would much prefer that be obvious in the priority. e.g
MAX_NMI_PRIORITY, which oprofile uses, then watchdog is MAX_NMI_PRIORITY
-1. Currently the gap between the two values you use indicates it's OK
to have another handler inbetween, which it definitely isn't.
regards
john
next prev parent reply other threads:[~2002-11-17 1:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-15 4:30 NMI handling rework for x86 Corey Minyard
2002-11-15 4:40 ` Zwane Mwaikambo
2002-11-15 6:10 ` Dipankar Sarma
2002-11-15 7:40 ` Zwane Mwaikambo
2002-11-15 8:13 ` Dipankar Sarma
2002-11-15 8:18 ` Zwane Mwaikambo
2002-11-15 8:50 ` Dipankar Sarma
2002-11-15 17:41 ` John Levon
2002-11-15 22:46 ` Zwane Mwaikambo
2002-11-15 5:12 ` John Levon
2002-11-15 5:19 ` John Levon
2002-11-15 14:13 ` Corey Minyard
2002-11-15 17:48 ` John Levon
2002-11-15 19:00 ` Corey Minyard
2002-11-15 19:28 ` John Levon
2002-11-15 19:35 ` Corey Minyard
2002-11-17 2:00 ` John Levon [this message]
2002-11-17 2:31 ` Zwane Mwaikambo
2002-11-18 16:48 ` Corey Minyard
2002-11-18 15:34 ` Corey Minyard
2002-11-15 5:20 ` Randy.Dunlap
2002-11-15 9:50 ` Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021117020017.GA96715@compsoc.man.ac.uk \
--to=levon@movementarian.org \
--cc=cminyard@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=zwane@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.