From: Christoph Hellwig <hch@lst.de>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: James.Bottomley@steeleye.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] rationalize allocation and freeing of struct scsi_device
Date: Mon, 18 Nov 2002 19:44:24 +0100 [thread overview]
Message-ID: <20021118194424.A16780@lst.de> (raw)
In-Reply-To: <20021118102410.A19492@eng2.beaverton.ibm.com>; from patmans@us.ibm.com on Mon, Nov 18, 2002 at 10:24:10AM -0800
On Mon, Nov 18, 2002 at 10:24:10AM -0800, Patrick Mansfield wrote:
> On Sun, Nov 17, 2002 at 11:49:01PM +0100, Christoph Hellwig wrote:
> > Currently allocation and freeing of struct scsi_device is a mess.
> > We have two nice functions in scsi_scan.c (scsi_allocate_sdev/
> > scsi_free_sdev) that are the right interfaces to deal with it, so I moved
> > them to scsi and made them non-static. I've changed all functions
> > allocation freeing them to use it.
>
> What happened to the scsi_release_sdev that was in your previous version
> of the patch?
That will follow in another patch.
> That was a nice place to call device_unregister(), and would be the right
> place to remove sysfs scsi_device files.
Right. But I also want to add such a wrapper for the alloc path, too
before submitting it.
next prev parent reply other threads:[~2002-11-18 18:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-17 22:49 [PATCH] rationalize allocation and freeing of struct scsi_device Christoph Hellwig
2002-11-18 18:24 ` Patrick Mansfield
2002-11-18 18:44 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-11-09 0:57 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021118194424.A16780@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.