From: Russell King <rmk@arm.linux.org.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] More missing includes [1/4]
Date: Tue, 19 Nov 2002 00:23:05 +0000 [thread overview]
Message-ID: <20021119002305.G21571@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20021118161947.B16391@twiddle.net>; from rth@twiddle.net on Mon, Nov 18, 2002 at 04:19:47PM -0800
On Mon, Nov 18, 2002 at 04:19:47PM -0800, Richard Henderson wrote:
> On Mon, Nov 18, 2002 at 11:17:45PM +0000, Russell King wrote:
> > The more obvious solution is to remove the __initdata from the
> > declaration on line 545. Such usage of __initdata (and __init)
> > serves no purpose.
>
> Yes it does. If the variable is small, then the compiler may
> expect the variable to be placed in the .sdata section, and so
> be reachable by, say, a 16-bit gp-relative relocation.
>
> Now, this variable in particular may not be small enough for
> that, but the fact remains that the general rule should be that
> variables should be declared with their section attributes.
Sigh, which is contary to what Christoph told me. Fine, have it your
own way.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
prev parent reply other threads:[~2002-11-19 0:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-18 22:16 [PATCH] More missing includes [1/4] Geert Uytterhoeven
2002-11-18 23:17 ` Russell King
2002-11-19 0:19 ` Richard Henderson
2002-11-19 0:23 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021119002305.G21571@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.