From: Jens Axboe <axboe@suse.de>
To: Robert Love <rml@tech9.net>
Cc: akpm@digeo.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] remove magic numbers in block queue initialization
Date: Wed, 20 Nov 2002 09:44:01 +0100 [thread overview]
Message-ID: <20021120084401.GH11884@suse.de> (raw)
In-Reply-To: <1037747198.1252.2259.camel@phantasy>
On Tue, Nov 19 2002, Robert Love wrote:
> Andrew,
>
> Your less-requests patch signaled a way-too-many magic numbers alarm
> (not the patches fault, of course, but it pointed it out).
>
> Attached patch removes the minimum queue length, maximum queue length,
> factor of queue length that is number of batch requests, and the maximum
> number of batch request magic numbers and replaces them with defines and
> some comments.
>
> Look OK?
No, please leave these alone, testing is on-going in these parts right
now.
--
Jens Axboe
next prev parent reply other threads:[~2002-11-20 8:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-19 23:06 [patch] remove magic numbers in block queue initialization Robert Love
2002-11-19 23:17 ` Robert Love
2002-11-19 23:18 ` Andrew Morton
2002-11-19 23:21 ` Robert Love
2002-11-20 8:44 ` Jens Axboe [this message]
2002-11-20 10:21 ` Robert Love
2002-11-20 10:25 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021120084401.GH11884@suse.de \
--to=axboe@suse.de \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.