From: Roger Luethi <rl@hellgate.ch>
To: Linus Torvalds <torvalds@transmeta.com>,
Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org, linux-ns83820@kvack.org
Subject: [PATCH][2.4/2.5] Fix ns83820 ioctl oops
Date: Tue, 26 Nov 2002 13:27:30 +0100 [thread overview]
Message-ID: <20021126122730.GA5484@k3.hellgate.ch> (raw)
[-- Attachment #1: Type: text/plain, Size: 188 bytes --]
Patch fixes the line mistaking a null pointer for an actual reference.
Also, to prevent this from happening again, the null pointer now is
replaced with the real one. Please apply.
Roger
[-- Attachment #2: ns83820.c.diff --]
[-- Type: text/plain, Size: 692 bytes --]
--- drivers/net/ns83820.c.orig Wed Nov 20 12:51:37 2002
+++ drivers/net/ns83820.c Tue Nov 26 12:51:39 2002
@@ -1214,7 +1214,7 @@ static int ns83820_ethtool_ioctl (struct
static int ns83820_ioctl(struct net_device *_dev, struct ifreq *rq, int cmd)
{
- struct ns83820 *dev = _dev->priv;
+ struct ns83820 *dev = (struct ns83820 *)_dev;
switch(cmd) {
case SIOCETHTOOL:
@@ -1788,6 +1788,7 @@ static int __devinit ns83820_init_one(st
dev->ee.cache = &dev->MEAR_cache;
dev->ee.lock = &dev->misc_lock;
dev->net_dev.owner = THIS_MODULE;
+ dev->net_dev.priv = dev;
PREPARE_TQUEUE(&dev->tq_refill, queue_refill, dev);
tasklet_init(&dev->rx_tasklet, rx_action, (unsigned long)dev);
reply other threads:[~2002-11-26 12:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021126122730.GA5484@k3.hellgate.ch \
--to=rl@hellgate.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ns83820@kvack.org \
--cc=marcelo@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.