From: Ralf Baechle <ralf@linux-mips.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Marc Zyngier <mzyngier@freesurf.fr>,
Linux/m68k <linux-m68k@lists.linux-m68k.org>,
Linux/MIPS Development <linux-mips@linux-mips.org>
Subject: Re: cli/sti removal from wd33c93.c
Date: Tue, 26 Nov 2002 13:54:25 +0100 [thread overview]
Message-ID: <20021126135425.A19238@linux-mips.org> (raw)
In-Reply-To: <Pine.GSO.4.21.0211261340040.18990-100000@vervain.sonytel.be>; from geert@linux-m68k.org on Tue, Nov 26, 2002 at 01:47:04PM +0100
On Tue, Nov 26, 2002 at 01:47:04PM +0100, Geert Uytterhoeven wrote:
> On Mon, 25 Nov 2002, Ralf Baechle wrote:
> > Below are patches to replace cli/sti and accomplices from the WD33c93
> > driver. Who is currently the maintainer of this driver? Ok to send to
> > Linus?
>
> Feel free to send it to Linus. Meanwhile I'll check it in in the m68k tree.
>
> > 2.5 doesn't boot on MIPS yet so this patch is untested. This patch gets
> > it to build; it was written by Marc Zygnier and reviewed by me and we
> > think it does the right thing.
>
> To me it looks OK as well. Unfortunately I don't have wd33c93 hardware (except
> in the old A500/A590, which doesn't run uClinux well/yet :-).
>
> BTW, am I correct in assuming that the driver is broken on 2.4.x as well?
> It looks like there are lots of paths in wd33c93_intr() where interrupts
> aren't properly restored.
I don't have any recent bug reports about the driver on SGI hardware. All
I can say it feels a little slow but I'm not sure how much I can expect
from my good ol' Indy. And I think it would gain from being fed through
Lindent ...
Ralf
next prev parent reply other threads:[~2002-11-28 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20021125123750.A11523@linux-mips.org>
2002-11-26 12:47 ` cli/sti removal from wd33c93.c Geert Uytterhoeven
2002-11-26 12:52 ` Marc Zyngier
2002-11-26 12:54 ` Ralf Baechle [this message]
2002-11-26 18:16 ` Kars de Jong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021126135425.A19238@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=mzyngier@freesurf.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.