From: Rusty Russell <rusty@rustcorp.com.au>
To: Thomas Molina <tmolina@copper.net>
Cc: linux-kernel@vger.kernel.org, Anders Gustafsson <andersg@0x63.nu>,
Steve Lord <lord@sgi.com>
Subject: Re: [RELEASE] module-init-tools 0.8
Date: Fri, 29 Nov 2002 11:59:49 +1100 [thread overview]
Message-ID: <20021129013010.38C262C2BA@lists.samba.org> (raw)
In-Reply-To: Your message of "Wed, 27 Nov 2002 23:55:08 MDT." <Pine.LNX.4.44.0211272325370.924-100000@lap.molina>
In message <Pine.LNX.4.44.0211272325370.924-100000@lap.molina> you write:
> With the patch you included, I get the following:
>
> In file included from include/linux/raid/md.h:27,
> from init/do_mounts.c:25:
> include/linux/module.h:159: parse error before "Elf32_Sym"
Argh.... Put back the #include <linux/elf.h> at the top of the file.
It's required for CONFIG_KALLSYMS=y.
The main reason for separating out moduleloader.h was so modules.h
didn't include elf.h, because xfs defines AT_GID and AT_UID itself.
The kallsyms patch put that back.
We could make module.symtab a void*, but that's just wrong. I think
we actually have to solve this clash, rather than hack around it,
since this is going to be a recurring problem.
Steve? Changing the prefix on xfs or elf seems equally painful (xfs
because it'll be a big patch, elf because it's standardized and been
like that forever).
Thoughts?
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next parent reply other threads:[~2002-11-29 1:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.44.0211272325370.924-100000@lap.molina>
2002-11-29 0:59 ` Rusty Russell [this message]
2002-11-29 1:45 ` [RELEASE] module-init-tools 0.8 Nathan Scott
2002-11-29 2:24 ` Thomas Molina
2002-11-29 2:50 ` Keith Owens
2002-11-29 3:41 ` Thomas Molina
2002-11-28 2:28 Rusty Russell
2002-11-28 16:16 ` Gerd Knorr
2002-11-28 17:09 ` Bill Davidsen
2002-11-28 18:22 ` Tomas Szepe
2002-11-28 23:47 ` Christoph Hellwig
2002-11-28 22:49 ` Jan-Benedict Glaw
2002-11-28 18:23 ` Gerd Knorr
2002-11-28 20:52 ` Marco d'Itri
2002-11-29 3:18 ` Rusty Russell
2002-11-29 2:38 ` Rusty Russell
2002-11-29 10:00 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021129013010.38C262C2BA@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=andersg@0x63.nu \
--cc=linux-kernel@vger.kernel.org \
--cc=lord@sgi.com \
--cc=tmolina@copper.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.