From: Adrian Bunk <bunk@fs.tum.de>
To: Bill Davidsen <davidsen@tmr.com>, Jeff Garzik <jgarzik@pobox.com>
Cc: Linux-Kernel <linux-kernel@vger.kernel.org>,
"Randy.Dunlap" <rddunlap@osdl.org>
Subject: Re: [BUG]2.5.49-ac1 - more info on make error
Date: Mon, 2 Dec 2002 19:22:14 +0100 [thread overview]
Message-ID: <20021202182213.GC775@fs.tum.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0211271540270.7715-201000@bilbo.tmr.com>
On Wed, Nov 27, 2002 at 03:45:24PM -0500, Bill Davidsen wrote:
>...
Content-Description: config
>...
> CONFIG_HOTPLUG=y
>...
> #
> # Tulip family network device support
> #
> CONFIG_NET_TULIP=y
> CONFIG_DE2104X=y
>...
./drivers/net/tulip/de2104x.o(.data+0x74): undefined reference to `local
symbols in discarded section .exit.text'
In drivers/net/tulip/de2104x.c the function de_remove_on is __exit but
the pointer to it is __devexit_p.
Two possible solutions:
1. Make this driver hot-pluggable. Jeff Garzik vetoes against this
solution.
2. Change the __devexit_p to an #ifdef MODULE (it's ugly, but it lets
the driver compiles with all combinations of config options without
making it hot-pluggable):
--- drivers/net/tulip/de2104x.c.old 2002-12-02 19:16:24.000000000 +0100
+++ drivers/net/tulip/de2104x.c 2002-12-02 19:18:18.000000000 +0100
@@ -2217,8 +2217,9 @@
.name = DRV_NAME,
.id_table = de_pci_tbl,
.probe = de_init_one,
-#warning only here to fix build. should be __exit_p not __devexit_p.
- .remove = __devexit_p(de_remove_one),
+#ifdef MODULE
+ .remove = de_remove_one,
+#endif
#ifdef CONFIG_PM
.suspend = de_suspend,
.resume = de_resume,
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2002-12-02 18:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-27 20:45 [BUG]2.5.49-ac1 - more info on make error Bill Davidsen
2002-12-02 17:06 ` Randy.Dunlap
2002-12-02 19:02 ` Bill Davidsen
2002-12-02 19:05 ` Randy.Dunlap
2002-12-02 19:52 ` Bill Davidsen
2002-12-02 18:22 ` Adrian Bunk [this message]
2002-12-02 18:32 ` [PATCH] " Jeff Garzik
2002-12-02 19:44 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021202182213.GC775@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=davidsen@tmr.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.