atlas_serial_{in,out}

atlas_serial_{in,out}

[Geert Uytterhoeven]

	Hi,

The MIPS 2.4.x drivers/char/serial.c differs from the upstream version by the
addition of hooks for the Atlas serial ports. However, I cannot find where
those hooks (atlas_serial_{in,out}) are actualy defined.

Did I overlook something, or is this a leftover from obsolete code?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: atlas_serial_{in,out}

[Carsten Langgaard]

They should have been in arch/mips/mips-boards/generic/printf.c, but they have
been removed, apparently.
Ralf, do you have any comment on why this code has been removed.

/Carsten



Geert Uytterhoeven wrote:

>         Hi,
>
> The MIPS 2.4.x drivers/char/serial.c differs from the upstream version by the
> addition of hooks for the Atlas serial ports. However, I cannot find where
> those hooks (atlas_serial_{in,out}) are actualy defined.
>
> Did I overlook something, or is this a leftover from obsolete code?
>
> Gr{oetje,eeting}s,
>
>                                                 Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                                             -- Linus Torvalds

--
_    _ ____  ___   Carsten Langgaard   Mailto:carstenl@mips.com
|\  /|||___)(___   MIPS Denmark        Direct: +45 4486 5527
| \/ |||    ____)  Lautrupvang 4B      Switch: +45 4486 5555
  TECHNOLOGIES     2750 Ballerup       Fax...: +45 4486 5556
                   Denmark             http://www.mips.com

Re: atlas_serial_{in,out}

[Ralf Baechle]

On Mon, Dec 02, 2002 at 01:10:08PM +0100, Carsten Langgaard wrote:

> They should have been in arch/mips/mips-boards/generic/printf.c, but they have
> been removed, apparently.
> Ralf, do you have any comment on why this code has been removed.

Simply a glitch when cleaning in arch/mips/mips-boards/generic/printf.c.

Btw, that file seem to follow the motto "generic due to ifdef" ;-)

  Ralf

Re: atlas_serial_{in,out}

[Carsten Langgaard]

Ralf Baechle wrote:

> On Mon, Dec 02, 2002 at 01:10:08PM +0100, Carsten Langgaard wrote:
>
> > They should have been in arch/mips/mips-boards/generic/printf.c, but they have
> > been removed, apparently.
> > Ralf, do you have any comment on why this code has been removed.
>
> Simply a glitch when cleaning in arch/mips/mips-boards/generic/printf.c.
>
> Btw, that file seem to follow the motto "generic due to ifdef" ;-)
>

Isn't the ifdef wonderful ;-)
A guess it's always a matter of compromise, tring to avoid the ifdef and sharing as
much code as possible.


>
>   Ralf

--
_    _ ____  ___   Carsten Langgaard   Mailto:carstenl@mips.com
|\  /|||___)(___   MIPS Denmark        Direct: +45 4486 5527
| \/ |||    ____)  Lautrupvang 4B      Switch: +45 4486 5555
  TECHNOLOGIES     2750 Ballerup       Fax...: +45 4486 5556
                   Denmark             http://www.mips.com