All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@sgi.com>
To: torvalds@transmeta.com, viro@math.psu.edu
Cc: linux-fsdevel@vger.kernel.org
Subject: [PATCH] remove bad inodes from hash table
Date: Tue, 3 Dec 2002 20:53:25 -0500	[thread overview]
Message-ID: <20021203205325.A1065@sgi.com> (raw)

When testing the XFS 1.2 release we found a problem that was caused
by inodes made unusable by make_bad_inode() still beeing returned by
iget() and friends.  The workaround was to call remove_inode_hash()
before each call to make_bad_inode().

I think the proper fix is to let make_bad_inode() remove the inodes
from the hash chains.


--- 1.7/fs/bad_inode.c	Tue Sep 17 21:52:27 2002
+++ edited/fs/bad_inode.c	Tue Dec  3 19:20:54 2002
@@ -84,6 +84,8 @@
  
 void make_bad_inode(struct inode * inode) 
 {
+	remove_inode_hash(inode);
+
 	inode->i_mode = S_IFREG;
 	inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
 	inode->i_op = &bad_inode_ops;	

                 reply	other threads:[~2002-12-04  1:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021203205325.A1065@sgi.com \
    --to=hch@sgi.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.