From: "David S. Miller" <davem@redhat.com>
To: david@gibson.dropbear.id.au
Cc: adam@yggdrasil.com, James.Bottomley@steeleye.com,
jgarzik@pobox.com, linux-kernel@vger.kernel.org, miles@gnu.org
Subject: Re: [RFC] generic device DMA implementation
Date: Thu, 05 Dec 2002 20:03:31 -0800 (PST) [thread overview]
Message-ID: <20021205.200331.127813001.davem@redhat.com> (raw)
In-Reply-To: <20021206025303.GC17829@zax.zax>
I think it's a huge error to try and move the DMA stuff into
the generic device interfaces _AND_ change semantics and arguments
at the same time.
Each operation should be done in seperate steps.
Then, if you want to talk about changing semantics etc. there are
more pressing needs (read as: real bugs) in the current DMA APIs
that must be fixed before you add new "cool" features to the
interfaces. For example, we have a "pci_dma_sync_*()" interface
which changes ownership from the device back to the cpu, but we
do not have the corollary which returns ownership of the DMA buffer
back to the device. Basically, every networking device driver that
recycles buffers using pci_dma_sync_*() to peak at the header but then
gives the buffer back to the device is buggy for this reason.
Fix this before changing stuff.
I don't have any time to discuss this further so please do me a big
favor and drop me from the CC: lists, I've been able to only lightly
read the existing parts of this thread, if at all, so the postings
will only hit /dev/null while I'm so busy right now.
Thanks.
next prev parent reply other threads:[~2002-12-06 3:59 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-06 2:08 [RFC] generic device DMA implementation Adam J. Richter
2002-12-06 2:53 ` David Gibson
2002-12-06 4:03 ` David S. Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-12-07 14:37 Adam J. Richter
2002-12-07 4:12 Adam J. Richter
2002-12-06 22:52 Adam J. Richter
2002-12-06 22:17 Adam J. Richter
2002-12-06 22:26 ` James Bottomley
2002-12-06 22:29 ` David S. Miller
2002-12-06 22:48 ` James Bottomley
2002-12-06 22:49 ` David S. Miller
2002-12-06 22:32 ` Arjan van de Ven
2002-12-06 17:39 Adam J. Richter
2002-12-06 18:07 ` Matthew Wilcox
2002-12-06 17:07 Adam J. Richter
2002-12-06 16:48 James Bottomley
2002-12-06 16:19 Adam J. Richter
2002-12-06 16:40 ` Matthew Wilcox
2002-12-06 18:17 ` David S. Miller
2002-12-06 18:29 ` James Bottomley
2002-12-06 18:31 ` David S. Miller
2002-12-06 18:40 ` James Bottomley
2002-12-06 18:42 ` David S. Miller
2002-12-06 21:04 ` Oliver Xymoron
2002-12-07 10:19 ` David Gibson
2002-12-06 18:36 ` Matthew Wilcox
2002-12-06 18:38 ` David S. Miller
2002-12-06 7:41 Adam J. Richter
2002-12-06 15:50 ` David S. Miller
2002-12-06 7:14 Adam J. Richter
2002-12-06 16:26 ` James Bottomley
2002-12-06 17:48 ` Miles Bader
2002-12-07 9:56 ` David Gibson
2002-12-07 9:45 ` David Gibson
2002-12-07 11:26 ` Russell King
2002-12-08 5:28 ` David Gibson
2002-12-06 6:15 David Brownell
2002-12-05 20:27 Adam J. Richter
2002-12-05 17:49 Manfred Spraul
2002-12-06 0:08 ` David Gibson
2002-12-05 12:21 Adam J. Richter
2002-12-05 12:44 ` Russell King
2002-12-05 12:13 Adam J. Richter
2002-12-05 11:57 Adam J. Richter
2002-12-06 0:06 ` David Gibson
2002-12-05 5:20 Adam J. Richter
2002-12-05 3:02 Adam J. Richter
2002-12-05 6:15 ` David Gibson
2002-12-05 1:21 Adam J. Richter
2002-12-05 2:40 ` David Gibson
2002-12-05 2:49 ` Miles Bader
2002-12-05 6:12 ` David Gibson
2002-12-05 0:43 Adam J. Richter
2002-12-05 0:55 ` Jeff Garzik
2002-12-05 2:02 ` James Bottomley
2002-12-04 17:47 James Bottomley
2002-12-04 18:27 ` Jeff Garzik
2002-12-04 19:36 ` James Bottomley
2002-12-04 21:19 ` Miles Bader
2002-12-04 21:21 ` Miles Bader
2002-12-04 21:42 ` James Bottomley
2002-12-05 5:44 ` Miles Bader
2002-12-04 21:46 ` James Bottomley
2002-12-05 2:31 ` Miles Bader
2002-12-05 3:06 ` James Bottomley
2002-12-05 5:02 ` David Gibson
2002-12-05 11:15 ` Benjamin Herrenschmidt
2002-12-05 11:16 ` William Lee Irwin III
2002-12-05 15:12 ` James Bottomley
2002-12-05 0:47 ` David Gibson
2002-12-05 0:54 ` Jeff Garzik
2002-12-05 1:44 ` James Bottomley
2002-12-05 2:38 ` David Gibson
2002-12-05 3:13 ` James Bottomley
2002-12-05 5:05 ` David Gibson
2002-12-05 15:03 ` James Bottomley
2002-12-05 23:54 ` David Gibson
2002-12-05 3:17 ` Miles Bader
2002-12-05 6:06 ` David Gibson
2002-12-05 6:43 ` Miles Bader
2002-12-05 23:44 ` David Gibson
2002-12-06 2:23 ` Miles Bader
2002-12-05 3:41 ` Jeff Garzik
2002-12-05 6:04 ` David Gibson
2002-12-05 16:29 ` Jeff Garzik
2002-12-05 23:59 ` David Gibson
2002-12-05 11:08 ` Benjamin Herrenschmidt
2002-12-05 11:35 ` Russell King
2002-12-05 15:24 ` James Bottomley
2002-12-06 0:01 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021205.200331.127813001.davem@redhat.com \
--to=davem@redhat.com \
--cc=James.Bottomley@steeleye.com \
--cc=adam@yggdrasil.com \
--cc=david@gibson.dropbear.id.au \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miles@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.