From: "David S. Miller" <davem@redhat.com>
To: raul@pleyades.net
Cc: linux-kernel@vger.kernel.org, marcelo@conectiva.com.br
Subject: Re: [BK-2.4] [PATCH] Small do_mmap_pgoff correction
Date: Tue, 10 Dec 2002 17:06:44 -0800 (PST) [thread overview]
Message-ID: <20021210.170644.97772177.davem@redhat.com> (raw)
In-Reply-To: <20021210222842.GA64@DervishD>
From: DervishD <raul@pleyades.net>
Date: Tue, 10 Dec 2002 23:28:42 +0100
> How about something like:
>
> if (len == 0)
> return addr;
>
> len = PAGE_ALIGN(len);
> if (len > TASK_SIZE || len == 0)
> return -EINVAL;
>
> That should cover all cases and not make the TASK_SIZE assumption.
Perfect :) If you want, I can make the patch and tell to Alan and
Linus. Anyway, I think you will better heared than me O:))
If you could take care of this, I would really be happy.
Anyway, I'll take a look at a new macro (lets say PAGE_ALIGN_SIZE
or something as ugly as this ;)))
How many places do we try to apply PAGE_ALIGN to a length?
If it's just one or two spots, perhaps the special macro
isn't worthwhile.
next prev parent reply other threads:[~2002-12-11 1:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200212101931.gBAJV1K10639@hera.kernel.org>
2002-12-10 20:19 ` [BK-2.4] [PATCH] Small do_mmap_pgoff correction David S. Miller
2002-12-10 20:45 ` DervishD
2002-12-10 20:47 ` David S. Miller
2002-12-10 20:59 ` DervishD
2002-12-10 21:22 ` David S. Miller
2002-12-10 18:52 ` Marcelo Tosatti
2002-12-10 22:13 ` DervishD
2002-12-10 22:14 ` David S. Miller
2002-12-10 22:28 ` DervishD
2002-12-11 1:06 ` David S. Miller [this message]
2002-12-11 12:32 ` DervishD
2002-12-10 20:50 [BK-2.4] [Patch] " DervishD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021210.170644.97772177.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=raul@pleyades.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.