Re: GDB patch

[Daniel Jacobowitz <dan@debian.org>]

On Tue, Dec 10, 2002 at 01:07:31PM +0100, Carsten Langgaard wrote:
> I've attached a patch for gdb-stub.c to make it work better with the
> sde-gdb.
> These changes should be backwards compatible with a standard gdb, so it
> shouldn't break anything.
> Ralf, could you please apply it.

Strongly object.  While I didn't check the implementation, it's nice to
see 'X' implemented.  And P.  But what the heck is this?

> @@ -816,13 +839,64 @@
>  		case 'k' :
>  			break;		/* do nothing */
>  
> +		case 'R':
> +			/* RNN[:SS],	Set the value of CPU register NN (size SS) */
> +			/* FALL THROUGH */

> -		/*
> -		 * Reset the whole machine (FIXME: system dependent)
> -		 */
>  		case 'r':
> -			break;
> +			/* rNN[:SS]	Return the value of CPU register NN (size SS) */


We're not making up a protocol here, we're implementing one.  R and r
don't have anything to do with setting registers.

> +		case 'D':
> +			putpacket("OK");
> +			return;
> +			/* NOTREACHED */
>  
>  		/*
>  		 * Step to next instruction

'D' should generally resume the machine, by the way.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer