Problems using /proc/scsi/gdth/ with 2.4.20aa1

Problems using /proc/scsi/gdth/ with 2.4.20aa1

[Oliver Jehle]

Running linux 2.4.20-aa1 and the gdth driver works ,but accessing
/proc/scsi/gdth/0 for example with cat or the supplied icpcon utility
don't work...

these messages are in system log when accessing /proc/scsi/gdth/0 with
cat for example (works with 2.4.18)
...

Dec 10 06:37:47 arena1 kernel: Unable to handle kernel NULL pointer
dereference at virtual address 00000000
Dec 10 06:37:47 arena1 kernel:  printing eip:
Dec 10 06:37:47 arena1 kernel: c024c879
Dec 10 06:37:47 arena1 kernel: *pde = 00000000
Dec 10 06:37:47 arena1 kernel: Oops: 0002 2.4.20aa1 #2 SMP Mon Dec 9
16:55:18 CET 2002
Dec 10 06:37:47 arena1 kernel: CPU:    0
Dec 10 06:37:47 arena1 kernel: EIP:   
0010:[scsi_release_commandblocks+17/92]    Not tainted
Dec 10 06:37:47 arena1 kernel: EFLAGS: 00010046
Dec 10 06:37:47 arena1 kernel: eax: 00000000   ebx: c283c000   ecx:
00000000   edx: 000000bd
Dec 10 06:37:47 arena1 kernel: esi: c283c000   edi: c283c018   ebp:
00000246   esp: c96a1b24
Dec 10 06:37:47 arena1 kernel: ds: 0018   es: 0018   ss: 0018
Dec 10 06:37:47 arena1 kernel: Process cat (pid: 2573,
stackpage=c96a1000)
Dec 10 06:37:47 arena1 kernel: Stack: c283c000 c92ce600 c283c000
c039f000 c024da34 c283c000 c283c018 00000c44
Dec 10 06:37:47 arena1 kernel:        c0258cd8 c283c000 c92ce600
00000c00 00000000 c96af000 00000c00 00000001
Dec 10 06:37:47 arena1 kernel:        c96a1db4 00000a10 c044a0c4
00000060 00000296 c96a1be8 c96a1bd8 c96a1db4
Dec 10 06:37:47 arena1 kernel: Call Trace:    [scsi_free_host_dev+44/56]
[gdth_get_info+4972/5048] [do_no_page+470/844] [handle_mm_fault+125/344]
[do_page_fault+0/1445]
Dec 10 06:37:47 arena1 kernel:   [rb_insert_color+81/196]
[__vma_link+98/176] [error_code+52/60] [__vma_link+98/176]
[error_code+52/60] [clear_user+46/60]
Dec 10 06:37:47 arena1 kernel:   [padzero+28/32]
[load_elf_binary+2381/2760] [load_elf_binary+0/2760]
[__alloc_pages+122/708] [getblk+56/108] [getblk+99/108]
Dec 10 06:37:47 arena1 kernel:   [gdth_proc_info+144/152]
[proc_scsi_read+68/96] [proc_file_read+262/440] [sys_read+143/256]
[system_call+51/56]
Dec 10 06:37:47 arena1 kernel: Code: f0 fe 08 0f 88 68 14 00 00 8b 86 a8
00 00 00 85 c0 74 1c 8d

Re: Problems using /proc/scsi/gdth/ with 2.4.20aa1

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

On Tue, Dec 10, 2002 at 07:49:00AM +0100, Oliver Jehle wrote:
> Running linux 2.4.20-aa1 and the gdth driver works ,but accessing
> /proc/scsi/gdth/0 for example with cat or the supplied icpcon utility
> don't work...
> 
> these messages are in system log when accessing /proc/scsi/gdth/0 with
> cat for example (works with 2.4.18)
> ...
> 
> Dec 10 06:37:47 arena1 kernel: Unable to handle kernel NULL pointer
> dereference at virtual address 00000000
> Dec 10 06:37:47 arena1 kernel:  printing eip:
> Dec 10 06:37:47 arena1 kernel: c024c879
> Dec 10 06:37:47 arena1 kernel: *pde = 00000000
> Dec 10 06:37:47 arena1 kernel: Oops: 0002 2.4.20aa1 #2 SMP Mon Dec 9
> 16:55:18 CET 2002
> Dec 10 06:37:47 arena1 kernel: CPU:    0
> Dec 10 06:37:47 arena1 kernel: EIP:   
> 0010:[scsi_release_commandblocks+17/92]    Not tainted

/me chuckles

That looks *amazingly* familiar...a patch I wrote introduced that bug,
sorry.  It's fix is attached (assuming that Andrea picked up the same
version of the 2.4.x iorl contention patch that we are using now, which 
is what introduced this problem for us here).

-- 
  Doug Ledford <dledford@redhat.com>     919-754-3700 x44233
         Red Hat, Inc. 
         1801 Varsity Dr.
         Raleigh, NC 27606
  

[-- Attachment #2: linux-2.4.9-gdthoops.patch --]
[-- Type: text/plain, Size: 745 bytes --]

--- linux/drivers/scsi/scsi.c-stock	Fri Oct 25 15:41:03 2002
+++ linux/drivers/scsi/scsi.c	Fri Oct 25 15:47:04 2002
@@ -2672,10 +2672,10 @@
         SDpnt->type = -1;
         SDpnt->queue_depth = 1;
         
-	scsi_build_commandblocks(SDpnt);
-
 	scsi_initialize_queue(SDpnt, SHpnt);
 
+	scsi_build_commandblocks(SDpnt);
+
 	SDpnt->online = TRUE;
 
         /*
@@ -2705,13 +2705,12 @@
                 panic("Attempt to delete wrong device\n");
         }
 
-        blk_cleanup_queue(&SDpnt->request_queue);
-
         /*
          * We only have a single SCpnt attached to this device.  Free
          * it now.
          */
 	scsi_release_commandblocks(SDpnt);
+        blk_cleanup_queue(&SDpnt->request_queue);
         kfree(SDpnt);
 }