From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@suse.de>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
dougg@torque.net, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] 2.5.51 SCSI_IOCTL_GET_IDLUN + _GET_BUS_NUMBER
Date: Thu, 12 Dec 2002 20:39:03 +0000 [thread overview]
Message-ID: <20021212203903.A8484@infradead.org> (raw)
In-Reply-To: <20021212174241.GB6481@suse.de>; from axboe@suse.de on Thu, Dec 12, 2002 at 06:42:41PM +0100
On Thu, Dec 12, 2002 at 06:42:41PM +0100, Jens Axboe wrote:
> Hmm, I _may_ be wrong but I think the main reason for GET_IDLUN and
> GET_BUS_NUMBER in the generic block layer is to stop them from failing
> in libscg and thus fooling it into believing we are scsi. You would need
> to check libscg/scsi-linux-sg.c to be sure.
>
> For one thing, we need to maintain the behaviour we have now of _not_
> failing them for ata devices. If you want to pass them down to SCSI as
> well and get the right id/lun and bus, fine, but don't break the ata
> one.
I disagree. USerspace needs changes to support SG_IO on block device anyway
so we should do it properly. There is no harm in changing interface during
2.5. IMHO most of the silly sg ioctl stubs in drivers/block/scsi_ioctl.c
should just die.
next prev parent reply other threads:[~2002-12-12 20:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-12 7:44 [PATCH] 2.5.51 SCSI_IOCTL_GET_IDLUN + _GET_BUS_NUMBER Douglas Gilbert
2002-12-12 14:27 ` James Bottomley
2002-12-12 17:42 ` Jens Axboe
2002-12-12 20:39 ` Christoph Hellwig [this message]
2002-12-12 20:40 ` Jens Axboe
2002-12-12 22:40 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021212203903.A8484@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@steeleye.com \
--cc=axboe@suse.de \
--cc=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.