Notification hooks

Notification hooks

[Ben Collins]

Linus, is there anyway I can request a hook so that anything that
changes drivers/ieee1394/ in your repo sends me an email with the diff
for just the files in that directory, and the changeset log? Is this
something that bkbits can do?

I'd bet lots of ppl would like similar hooks for their portions of the
source.

-- 
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
Deqo       - http://www.deqo.com/

Re: Notification hooks

[Arjan van de Ven]

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

On Mon, 2002-12-16 at 18:12, Ben Collins wrote:
> Linus, is there anyway I can request a hook so that anything that
> changes drivers/ieee1394/ in your repo sends me an email with the diff
> for just the files in that directory, and the changeset log? Is this
> something that bkbits can do?
> 
> I'd bet lots of ppl would like similar hooks for their portions of the
> source.

well there is the bk commits list that has all individual changesets.
Add procmail and the patchutils program "grepdiff" to the recipe and I
think we have a winner.....

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Notification hooks

[Larry McVoy]

On Mon, Dec 16, 2002 at 06:18:55PM +0100, Arjan van de Ven wrote:
> On Mon, 2002-12-16 at 18:12, Ben Collins wrote:
> > Linus, is there anyway I can request a hook so that anything that
> > changes drivers/ieee1394/ in your repo sends me an email with the diff
> > for just the files in that directory, and the changeset log? Is this
> > something that bkbits can do?
> > 
> > I'd bet lots of ppl would like similar hooks for their portions of the
> > source.
> 
> well there is the bk commits list that has all individual changesets.
> Add procmail and the patchutils program "grepdiff" to the recipe and I
> think we have a winner.....

I suspect you want to look at all the files in the cset.  I think what
you want is a script which is given a list of files and sends a patch
for each new changeset which touches any of those files.  Because if 
a changeset touched drivers/ieee1394/ and include/something then you
probably want both.

bk help triggers.
-- 
---
Larry McVoy            	 lm at bitmover.com           http://www.bitmover.com/lm 

Re: Notification hooks

[Ben Collins]

On Mon, Dec 16, 2002 at 09:21:29AM -0800, Larry McVoy wrote:
> On Mon, Dec 16, 2002 at 06:18:55PM +0100, Arjan van de Ven wrote:
> > On Mon, 2002-12-16 at 18:12, Ben Collins wrote:
> > > Linus, is there anyway I can request a hook so that anything that
> > > changes drivers/ieee1394/ in your repo sends me an email with the diff
> > > for just the files in that directory, and the changeset log? Is this
> > > something that bkbits can do?
> > > 
> > > I'd bet lots of ppl would like similar hooks for their portions of the
> > > source.
> > 
> > well there is the bk commits list that has all individual changesets.
> > Add procmail and the patchutils program "grepdiff" to the recipe and I
> > think we have a winner.....
> 
> I suspect you want to look at all the files in the cset.  I think what
> you want is a script which is given a list of files and sends a patch
> for each new changeset which touches any of those files.  Because if 
> a changeset touched drivers/ieee1394/ and include/something then you
> probably want both.
> 
> bk help triggers.

Well, if it affects more than just the files I am interested in, I only
want the diff for those files, but the changeset log and files-affected
for the whole changeset.

If I want the full diff I can go to bkbits or the archive of the commit
list.

-- 
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
Deqo       - http://www.deqo.com/

Re: Notification hooks

[Arjan van de Ven]

On Mon, Dec 16, 2002 at 12:27:22PM -0500, Ben Collins wrote:
> > bk help triggers.
> 
> Well, if it affects more than just the files I am interested in, I only
> want the diff for those files, but the changeset log and files-affected
> for the whole changeset.
> 
> If I want the full diff I can go to bkbits or the archive of the commit
> list.

well grepdiff and filterdiff can do that I bet... 
filterdiff takes a wildcard and only lets patches through that touch files
that match this wildcard...

Re: Notification hooks

[Ben Collins]

On Mon, Dec 16, 2002 at 05:28:38PM +0000, Arjan van de Ven wrote:
> On Mon, Dec 16, 2002 at 12:27:22PM -0500, Ben Collins wrote:
> > > bk help triggers.
> > 
> > Well, if it affects more than just the files I am interested in, I only
> > want the diff for those files, but the changeset log and files-affected
> > for the whole changeset.
> > 
> > If I want the full diff I can go to bkbits or the archive of the commit
> > list.
> 
> well grepdiff and filterdiff can do that I bet... 
> filterdiff takes a wildcard and only lets patches through that touch files
> that match this wildcard...

For all the people that suggested subscribing to the commit list, guess
what, I am.

Problem is that my changeset isn't even listed there. Not a very
dependable way to get that info.

-- 
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
Deqo       - http://www.deqo.com/

Re: Notification hooks

[David Woodhouse]

bcollins@debian.org said:
>  Problem is that my changeset isn't even listed there. Not a very
> dependable way to get that info. 

Isn't it? Why not? What changeset was it?

--
dwmw2

Re: Notification hooks

[Ben Collins]

On Tue, Dec 17, 2002 at 09:05:07AM +0000, David Woodhouse wrote:
> 
> bcollins@debian.org said:
> >  Problem is that my changeset isn't even listed there. Not a very
> > dependable way to get that info. 
> 
> Isn't it? Why not? What changeset was it?

Not in my mbox. Don't know. 1.863.3.1, according to bkbits.


-- 
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
Deqo       - http://www.deqo.com/

Re: Notification hooks

[Dave Jones]

On Mon, Dec 16, 2002 at 12:12:18PM -0500, Ben Collins wrote:
 > Linus, is there anyway I can request a hook so that anything that
 > changes drivers/ieee1394/ in your repo sends me an email with the diff
 > for just the files in that directory, and the changeset log? Is this
 > something that bkbits can do?
 > 
 > I'd bet lots of ppl would like similar hooks for their portions of the
 > source.

It'd be nice if the bkbits webpage had a "notify me" interface for files
in Linus' repository. This way not just the maintainers, but folks
interested in changes in that area can also see the changes.

As well as opening this up for more people, it'd also take the load
of Linus having to do it.

		Dave

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs

Re: Notification hooks

[Ben Collins]

On Mon, Dec 16, 2002 at 05:19:25PM +0000, Dave Jones wrote:
> On Mon, Dec 16, 2002 at 12:12:18PM -0500, Ben Collins wrote:
>  > Linus, is there anyway I can request a hook so that anything that
>  > changes drivers/ieee1394/ in your repo sends me an email with the diff
>  > for just the files in that directory, and the changeset log? Is this
>  > something that bkbits can do?
>  > 
>  > I'd bet lots of ppl would like similar hooks for their portions of the
>  > source.
> 
> It'd be nice if the bkbits webpage had a "notify me" interface for files
> in Linus' repository. This way not just the maintainers, but folks
> interested in changes in that area can also see the changes.
> 
> As well as opening this up for more people, it'd also take the load
> of Linus having to do it.

True. But if the load is too much for bkbits to handle, I'd like Linus
to consider it just for maintainers.

-- 
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
Deqo       - http://www.deqo.com/

Re: Notification hooks

[Larry McVoy]

> True. But if the load is too much for bkbits to handle, I'd like Linus
> to consider it just for maintainers.

bkbits can keep up, that's not the issue.  The main problem is coming up
with an interface that makes sense for people.  The mechanisms are all 
there already in the form of triggers.
-- 
---
Larry McVoy            	 lm at bitmover.com           http://www.bitmover.com/lm 

Re: Notification hooks

[Larry McVoy]

On Mon, Dec 16, 2002 at 05:19:25PM +0000, Dave Jones wrote:
> On Mon, Dec 16, 2002 at 12:12:18PM -0500, Ben Collins wrote:
>  > Linus, is there anyway I can request a hook so that anything that
>  > changes drivers/ieee1394/ in your repo sends me an email with the diff
>  > for just the files in that directory, and the changeset log? Is this
>  > something that bkbits can do?
>  > 
>  > I'd bet lots of ppl would like similar hooks for their portions of the
>  > source.
> 
> It'd be nice if the bkbits webpage had a "notify me" interface for files
> in Linus' repository. This way not just the maintainers, but folks
> interested in changes in that area can also see the changes.

Just for linux.bkbits.net or for the openlogging tree?  To remind people, 
linux.bkbits.net has Linus/Marcelo trees but openlogging.org has the 
union of all trees anywhere in the world.  And openlogging doesn't have
contents, it just has comments.  
-- 
---
Larry McVoy            	 lm at bitmover.com           http://www.bitmover.com/lm 

Re: Notification hooks

[Dave Jones]

On Mon, Dec 16, 2002 at 09:24:15AM -0800, Larry McVoy wrote:

 > > It'd be nice if the bkbits webpage had a "notify me" interface for files
 > > in Linus' repository. This way not just the maintainers, but folks
 > > interested in changes in that area can also see the changes.
 > 
 > Just for linux.bkbits.net or for the openlogging tree?  To remind people, 
 > linux.bkbits.net has Linus/Marcelo trees but openlogging.org has the 
 > union of all trees anywhere in the world.  And openlogging doesn't have
 > contents, it just has comments.  

I can't think of a practical use for doing this to the openlogging.org tree.

		Dave

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs

Re: Notification hooks

[Joseph Fannin]

[-- Attachment #1: Type: text/plain, Size: 2114 bytes --]

On Mon, Dec 16, 2002 at 09:24:15AM -0800, Larry McVoy wrote:
> On Mon, Dec 16, 2002 at 05:19:25PM +0000, Dave Jones wrote:
> > On Mon, Dec 16, 2002 at 12:12:18PM -0500, Ben Collins wrote:
> >  > Linus, is there anyway I can request a hook so that anything that
> >  > changes drivers/ieee1394/ in your repo sends me an email with the diff
> >  > for just the files in that directory, and the changeset log? Is this
> >  > something that bkbits can do?
> >  > 
> >  > I'd bet lots of ppl would like similar hooks for their portions of the
> >  > source.
> > 
> > It'd be nice if the bkbits webpage had a "notify me" interface for files
> > in Linus' repository. This way not just the maintainers, but folks
> > interested in changes in that area can also see the changes.
> 
> Just for linux.bkbits.net or for the openlogging tree?  To remind people, 
> linux.bkbits.net has Linus/Marcelo trees but openlogging.org has the 
> union of all trees anywhere in the world.  And openlogging doesn't have
> contents, it just has comments.  

    Sorry to hijack this thread like this, but I can't find a better
forum for it.

    Several times I have browsed linux source trees at bkbits.net and
found a changeset I have wanted to have as a patch.  I can search for
the changeset, and read the commit messages, and even read the patch
on the screen, but there is no good way to download that patch as a
file (viewing the page source doesn't help because the patch has html
markup interspersed with it).

    The only way to get the patch is to either 'scrape' the screen
with copy and paste and try to fix the broken whitespace or to use bk
to clone the entire tree and extract the patch via bk export.  It's a
real pain, and for no good reason I can see.

    Would it be possible to add a link to the bkbits.net pages to an
un-marked up changeset patch?  It would be great to have this for
trees other than linux.bkbits.net too -- like Dave Jones'
agpgart.bkbits.net for example.

-- 
Joseph Fannin
jhf@rivenstone.net

"That's all I have to say about that." -- Forrest Gump.

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: Notification hooks

[Randy.Dunlap]

On Thu, 19 Dec 2002, Joseph Fannin wrote:

| On Mon, Dec 16, 2002 at 09:24:15AM -0800, Larry McVoy wrote:
| >
| > Just for linux.bkbits.net or for the openlogging tree?  To remind people,
| > linux.bkbits.net has Linus/Marcelo trees but openlogging.org has the
| > union of all trees anywhere in the world.  And openlogging doesn't have
| > contents, it just has comments.
|
|     Sorry to hijack this thread like this, but I can't find a better
| forum for it.
|
|     Several times I have browsed linux source trees at bkbits.net and
| found a changeset I have wanted to have as a patch.  I can search for
| the changeset, and read the commit messages, and even read the patch
| on the screen, but there is no good way to download that patch as a
| file (viewing the page source doesn't help because the patch has html
| markup interspersed with it).
|
|     The only way to get the patch is to either 'scrape' the screen
| with copy and paste and try to fix the broken whitespace or to use bk
| to clone the entire tree and extract the patch via bk export.  It's a
| real pain, and for no good reason I can see.
|
|     Would it be possible to add a link to the bkbits.net pages to an
| un-marked up changeset patch?  It would be great to have this for
| trees other than linux.bkbits.net too -- like Dave Jones'
| agpgart.bkbits.net for example.

Have you looked at the (text-mode) csets at
  http://www.kernel.org/pub/linux/kernel/v2.5/testing/cset/

Who generates these?

-- 
~Randy

Re: Notification hooks

[Greg KH]

On Mon, Dec 16, 2002 at 12:12:18PM -0500, Ben Collins wrote:
> Linus, is there anyway I can request a hook so that anything that
> changes drivers/ieee1394/ in your repo sends me an email with the diff
> for just the files in that directory, and the changeset log? Is this
> something that bkbits can do?

Just subscribe to the bk-commits-head mailing list, and then have
procmail set up a filter to alert you to anything that happens to files
in any specific directories.

Or do something else with the data sent on that mailing list, or look at
the changeset files on kernel.org that are constantly being generated.

There are lots of ways to get this information without relying on hooks
in bk.

Hope this helps,

greg k-h

Re: Notification hooks

[Christoph Hellwig]

On Mon, Dec 16, 2002 at 12:12:18PM -0500, Ben Collins wrote:
> Linus, is there anyway I can request a hook so that anything that
> changes drivers/ieee1394/ in your repo sends me an email with the diff
> for just the files in that directory, and the changeset log? Is this
> something that bkbits can do?

How about subscribing to the commits list throw away every mail not
containing ieee1394 with procmail (or $MAILFILTER)?