All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jun Sun <jsun@mvista.com>
To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	linux-mips@linux-mips.org, jsun@mvista.com
Subject: Re: [PATCH] add dispatch_i8259_irq() to i8259.c
Date: Tue, 17 Dec 2002 13:40:11 -0800	[thread overview]
Message-ID: <20021217134011.M11575@mvista.com> (raw)
In-Reply-To: <Pine.GSO.3.96.1021217131352.7289A-100000@delta.ds2.pg.gda.pl>; from macro@ds2.pg.gda.pl on Tue, Dec 17, 2002 at 02:39:21PM +0100

On Tue, Dec 17, 2002 at 02:39:21PM +0100, Maciej W. Rozycki wrote:
> > No MIPS boards are using do_slow_gettimeoffset().  We really should get
> > rid of it.
> 
>  I know none does at the moment.  But are you sure there is no system that
> would need it and might be supported one day?
>

I serisouly don't think so.  Moving forward every CPU will have a CPU counter,
which can be used for timeoffset purpose.  Even if it does not have one,
it will surely have some onboard high resolution timer, which can be used
to intra-jiffy offset purpose.

Anyway, this function is only defined in old-time.c, which will go away 
soon (hopefully). :-)

 
>  Here is an example (untested) code that I would recommend.  It sends
> explicit ACKs to the i8259As, which has the following advantages:
> 
<snip>

Cool.  This code works for me.

I studied it a little bit and I am convinced it is a better choice.
It should work for MIPS in general.

In my original code I did verify that the IRR bit is not cleared,
which apparently will be a problem in cases.

The only catch with your code is that we don't have iob() macro (which 
apparently is very useful).  Any suggestions on this?  Otherwise  
I will probably remove it.

Jun

  parent reply	other threads:[~2002-12-17 21:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-13 23:08 [PATCH] add dispatch_i8259_irq() to i8259.c Jun Sun
2002-12-14  0:55 ` Maciej W. Rozycki
2002-12-14  4:18   ` Ralf Baechle
2002-12-16 13:44     ` Maciej W. Rozycki
2002-12-16 20:40       ` Jun Sun
2002-12-17 13:39         ` Maciej W. Rozycki
2002-12-17 14:35           ` Dominic Sweetman
2002-12-17 18:23             ` Ralf Baechle
2002-12-17 18:33               ` Maciej W. Rozycki
2002-12-17 18:27             ` Maciej W. Rozycki
2002-12-17 19:54             ` Jun Sun
2002-12-17 21:40           ` Jun Sun [this message]
2002-12-18 16:14             ` Maciej W. Rozycki
2002-12-18 17:48               ` Jun Sun
2002-12-18 18:14                 ` Maciej W. Rozycki
2002-12-18 18:51                   ` Jun Sun
2002-12-18 19:26                     ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021217134011.M11575@mvista.com \
    --to=jsun@mvista.com \
    --cc=linux-mips@linux-mips.org \
    --cc=macro@ds2.pg.gda.pl \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.