From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Bjorn Helgaas <bjorn_helgaas@hp.com>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
mj@ucw.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: disable decoding while sizing BARs
Date: Tue, 17 Dec 2002 17:29:25 +0300 [thread overview]
Message-ID: <20021217172925.A15754@jurassic.park.msu.ru> (raw)
In-Reply-To: <200212161741.53287.bjorn_helgaas@hp.com>; from bjorn_helgaas@hp.com on Mon, Dec 16, 2002 at 05:41:53PM -0700
On Mon, Dec 16, 2002 at 05:41:53PM -0700, Bjorn Helgaas wrote:
> + /* Disable I/O & memory decoding while we size the BARs. */
> + pci_read_config_word(dev, PCI_COMMAND, &cmd);
> + pci_write_config_word(dev, PCI_COMMAND,
> + cmd & ~(PCI_COMMAND_IO | PCI_COMMAND_MEMORY));
It's fatal for certain x86 northbridges, that's why the code was
removed 2 years ago.
Maybe it would be ok with this modification:
pci_read_config_word(dev, PCI_COMMAND, &cmd);
/* Don't touch northbridges or devices with devfn 0:0 */
if ((dev->class >> 8) != PCI_CLASS_BRIDGE_HOST && dev->devfn)
pci_write_config_word(dev, PCI_COMMAND,
cmd & ~(PCI_COMMAND_IO | PCI_COMMAND_MEMORY));
Ivan.
next prev parent reply other threads:[~2002-12-17 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-17 0:41 [PATCH] PCI: disable decoding while sizing BARs Bjorn Helgaas
2002-12-17 14:29 ` Ivan Kokshaysky [this message]
2002-12-18 12:30 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021217172925.A15754@jurassic.park.msu.ru \
--to=ink@jurassic.park.msu.ru \
--cc=bjorn_helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=mj@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.