From: Dave Jones <davej@codemonkey.org.uk>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2.5] PCI: kill pdev_enable_device()
Date: Wed, 18 Dec 2002 00:42:26 +0000 [thread overview]
Message-ID: <20021218004226.GA3204@suse.de> (raw)
In-Reply-To: <3DFFA5DD.4030804@pobox.com>
On Tue, Dec 17, 2002 at 05:31:57PM -0500, Jeff Garzik wrote:
> Ivan Kokshaysky wrote:
> >- So, if we don't touch the PCI command registers, there is no point in
> > using pdev_enable_device(). Most drivers properly use
> > pci_enable_device() anyway.
> Not only that, a driver _should_ be calling pci-enable-device, it's an
> API requirement. J Random Driver should have a good reason _not_ to
> call pci_enable_device() ...
What about the xircom issue that was discussed in the last days ?
Sounds like the solution isn't a full on pci_enable_device() as
pcmcia 'knows better than us' at that stage aparently.
Dave
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
next prev parent reply other threads:[~2002-12-18 0:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-17 17:19 [patch 2.5] PCI: kill pdev_enable_device() Ivan Kokshaysky
2002-12-17 22:31 ` Jeff Garzik
2002-12-18 0:42 ` Dave Jones [this message]
2002-12-18 0:52 ` Jeff Garzik
2002-12-18 10:11 ` Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021218004226.GA3204@suse.de \
--to=davej@codemonkey.org.uk \
--cc=ink@jurassic.park.msu.ru \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.