All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vojtech Pavlik <vojtech@suse.cz>
To: John Reiser <jreiser@BitWagon.com>,
	AnonimoVeneziano <voloterreno@tin.it>,
	Patrick Petermair <black666@inode.at>,
	Roland Quast <rquast@hotshed.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: vt8235 fix, hopefully last variant
Date: Thu, 19 Dec 2002 11:26:40 +0100	[thread overview]
Message-ID: <20021219112640.A21164@ucw.cz> (raw)

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

Hi!

Can you guys try out this last take on a fix for your ATAPI device
problems? Applies against clean 2.4.20.

Please report failure/success.

Thanks.

-- 
Vojtech Pavlik
SuSE Labs

[-- Attachment #2: vt8235-atapi --]
[-- Type: text/plain, Size: 1331 bytes --]

ChangeSet@1.884, 2002-12-19 11:23:11+01:00, vojtech@suse.cz
  VIA IDE: Always use slow address setup timings for ATAPI devices.


 via82cxxx.c |   19 ++++++-------------
 1 files changed, 6 insertions(+), 13 deletions(-)


diff -Nru a/drivers/ide/pci/via82cxxx.c b/drivers/ide/pci/via82cxxx.c
--- a/drivers/ide/pci/via82cxxx.c	Thu Dec 19 11:23:42 2002
+++ b/drivers/ide/pci/via82cxxx.c	Thu Dec 19 11:23:42 2002
@@ -1,16 +1,5 @@
 /*
- * $Id: via82cxxx.c,v 3.35-ac2 2002/09/111 Alan Exp $
- *
- *  Copyright (c) 2000-2001 Vojtech Pavlik
- *
- *  Based on the work of:
- *	Michel Aubry
- *	Jeff Garzik
- *	Andre Hedrick
- */
-
-/*
- * Version 3.35
+ * Version 3.36
  *
  * VIA IDE driver for Linux. Supported southbridges:
  *
@@ -152,7 +141,7 @@
 	via_print("----------VIA BusMastering IDE Configuration"
 		"----------------");
 
-	via_print("Driver Version:                     3.35-ac");
+	via_print("Driver Version:                     3.36");
 	via_print("South Bridge:                       VIA %s",
 		via_config->name);
 
@@ -351,6 +340,10 @@
 		ide_timing_compute(peer, peer->current_speed, &p, T, UT);
 		ide_timing_merge(&p, &t, &t, IDE_TIMING_8BIT);
 	}
+
+	/* Always use 4 address setup clocks on ATAPI devices */
+	if (drive->media != ide_disk)
+		t.setup = 4;
 
 	via_set_speed(HWIF(drive)->pci_dev, drive->dn, &t);
 

             reply	other threads:[~2002-12-19 10:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-19 10:26 Vojtech Pavlik [this message]
2002-12-19 13:34 ` vt8235 fix, hopefully last variant AnonimoVeneziano
2002-12-19 17:41 ` John Reiser
2002-12-20 20:12 ` Patrick Petermair
2002-12-21  9:21   ` Vojtech Pavlik
2002-12-21 10:51     ` Patrick Petermair
2002-12-21 12:00       ` Vojtech Pavlik
2002-12-21  0:25 ` Christian Seidemann
2002-12-23 19:30   ` AnonimoVeneziano
2002-12-23 21:42     ` Patrick Petermair
2002-12-24  0:09       ` AnonimoVeneziano
2002-12-24  0:26         ` Patrick Petermair
2002-12-24  0:33           ` AnonimoVeneziano
2002-12-21 17:57 ` John Reiser
2002-12-21 18:27   ` Vojtech Pavlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021219112640.A21164@ucw.cz \
    --to=vojtech@suse.cz \
    --cc=black666@inode.at \
    --cc=jreiser@BitWagon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rquast@hotshed.com \
    --cc=voloterreno@tin.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.