* [PATCH]: fix type of MAXMEM
@ 2002-12-19 20:07 Juan Quintela
2002-12-20 2:37 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Juan Quintela @ 2002-12-19 20:07 UTC (permalink / raw)
To: Ralf Baechle, mipslist
Hi
I expect that the amount from where it is highmem to never be
bigger that 4Giga Megabytes :) I.e. int should be enough.
Later, Juan.
Index: arch/mips/kernel/setup.c
===================================================================
RCS file: /home/cvs/linux/arch/mips/kernel/setup.c,v
retrieving revision 1.96.2.34
diff -u -r1.96.2.34 setup.c
--- arch/mips/kernel/setup.c 11 Dec 2002 06:12:29 -0000 1.96.2.34
+++ arch/mips/kernel/setup.c 19 Dec 2002 19:48:41 -0000
@@ -306,7 +306,7 @@
max_low_pfn = MAXMEM_PFN;
#ifndef CONFIG_HIGHMEM
/* Maximum memory usable is what is directly addressable */
- printk(KERN_WARNING "Warning only %ldMB will be used.\n",
+ printk(KERN_WARNING "Warning only %dMB will be used.\n",
MAXMEM>>20);
printk(KERN_WARNING "Use a HIGHMEM enabled kernel.\n");
#endif
--
In theory, practice and theory are the same, but in practice they
are different -- Larry McVoy
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH]: fix type of MAXMEM
2002-12-19 20:07 [PATCH]: fix type of MAXMEM Juan Quintela
@ 2002-12-20 2:37 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2002-12-20 2:37 UTC (permalink / raw)
To: Juan Quintela; +Cc: mipslist
On Thu, Dec 19, 2002 at 09:07:17PM +0100, Juan Quintela wrote:
> I expect that the amount from where it is highmem to never be
> bigger that 4Giga Megabytes :) I.e. int should be enough.
No. The root cause of this problem is the type of the constant
HIGHMEM_START which should have been unsigned int but actually was
just int.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-12-20 2:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-12-19 20:07 [PATCH]: fix type of MAXMEM Juan Quintela
2002-12-20 2:37 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.