From: Vojtech Pavlik <vojtech@suse.cz>
To: mdew <mdew@orcon.net.nz>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
"torvalds@transmeta.com" <torvalds@transmeta.com>,
Vojtech Pavlik <vojtech@suse.cz>, Greg KH <greg@kroah.com>
Subject: Re: [PATCH 2.5] [TRIVIAL] USB Joypad quirk
Date: Sun, 22 Dec 2002 13:14:22 +0100 [thread overview]
Message-ID: <20021222131422.A507@ucw.cz> (raw)
In-Reply-To: <1040556042.9822.17.camel@nirvana>; from mdew@orcon.net.nz on Mon, Dec 23, 2002 at 12:20:30AM +1300
On Mon, Dec 23, 2002 at 12:20:30AM +1300, mdew wrote:
> Orginally from Vojtech Pavlik (16th June 2002 via email), to fix my
> 'broken' USB joypad, Fully tested in both 2.4.x and 2.5.52 (and
> 2.5.52-bk).
Yes, Greg, this can go in.
>
> -mdew
>
>
>
> diff -Naur a/drivers/usb/input/hid-core.c
> mdew/drivers/usb/input/hid-core.c
> --- a/drivers/usb/input/hid-core.c 2002-11-28 11:36:04.000000000 +1300
> +++ mdew/drivers/usb/input/hid-core.c 2002-12-22 23:37:51.000000000
> +1300
> @@ -1317,6 +1317,9 @@
> #define USB_DEVICE_ID_ATEN_2PORTKVM 0x2204
> #define USB_DEVICE_ID_ATEN_4PORTKVM 0x2205
>
> +#define USB_VENDOR_ID_TOPMAX 0x0663
> +#define USB_DEVICE_ID_TOPMAX_COBRAPAD 0x0103
> +
> #define USB_VENDOR_ID_MGE 0x0463
> #define USB_DEVICE_ID_MGE_UPS 0xffff
> #define USB_DEVICE_ID_MGE_UPS1 0x0001
> @@ -1355,6 +1358,7 @@
> { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_4PORTKVM, HID_QUIRK_NOGET },
> { USB_VENDOR_ID_MGE, USB_DEVICE_ID_MGE_UPS, HID_QUIRK_HIDDEV },
> { USB_VENDOR_ID_MGE, USB_DEVICE_ID_MGE_UPS1, HID_QUIRK_HIDDEV },
> + { USB_VENDOR_ID_TOPMAX, USB_DEVICE_ID_TOPMAX_COBRAPAD,
> HID_QUIRK_BADPAD },
> { 0, 0 }
> };
>
> diff -Naur a/drivers/usb/input/hid-input.c
> mdew/drivers/usb/input/hid-input.c
> --- a/drivers/usb/input/hid-input.c 2002-11-28 11:35:59.000000000 +1300
> +++ mdew/drivers/usb/input/hid-input.c 2002-12-22 23:41:25.000000000
> +1300
> @@ -357,6 +357,11 @@
> int a = field->logical_minimum;
> int b = field->logical_maximum;
>
> + if ((device->quirks & HID_QUIRK_BADPAD) && (usage->code == ABS_X ||
> usage->code == ABS_Y)) {
> + a = field->logical_minimum = 0;
> + b = field->logical_maximum = 255;
> + }
> +
> input->absmin[usage->code] = a;
> input->absmax[usage->code] = b;
> input->absfuzz[usage->code] = (b - a) >> 8;
> diff -Naur a/drivers/usb/input/hid.h mdew/drivers/usb/input/hid.h
> --- a/drivers/usb/input/hid.h 2002-11-28 11:35:46.000000000 +1300
> +++ mdew/drivers/usb/input/hid.h 2002-12-22 23:38:49.000000000 +1300
> @@ -206,6 +206,7 @@
> #define HID_QUIRK_IGNORE 0x04
> #define HID_QUIRK_NOGET 0x08
> #define HID_QUIRK_HIDDEV 0x10
> +#define HID_QUIRK_BADPAD 0x12
>
> /*
> * This is the global enviroment of the parser. This information is
>
--
Vojtech Pavlik
SuSE Labs
next prev parent reply other threads:[~2002-12-22 12:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-22 11:20 [PATCH 2.5] [TRIVIAL] USB Joypad quirk mdew
2002-12-22 12:14 ` Vojtech Pavlik [this message]
2002-12-23 19:12 ` Greg KH
2002-12-23 21:04 ` mdew
2002-12-23 22:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021222131422.A507@ucw.cz \
--to=vojtech@suse.cz \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mdew@orcon.net.nz \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.