All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: linux-kernel@vger.kernel.org
Subject: Re: [CFT] arch/alpha: Makefiles update
Date: Tue, 31 Dec 2002 15:35:39 -0800	[thread overview]
Message-ID: <20021231153539.A21946@twiddle.net> (raw)
In-Reply-To: <20021230115336.GA1089@mars.ravnborg.org>; from sam@ravnborg.org on Mon, Dec 30, 2002 at 12:53:36PM +0100

On Mon, Dec 30, 2002 at 12:53:36PM +0100, Sam Ravnborg wrote:
> +# If ALPHA_GENERIC, make sure to turn off any instruction set extensions
> +# that the host compiler might have on by default. Given that EV4 and EV5
> +# have the same instruction set, prefer EV5 because an EV5 schedule is
> +# more likely to keep an EV4 processor busy than vice-versa.
> + 
> +# Default value
> +mach-yy := ev56
> +mach-$(have_mcpu_pca56)$(have_mcpu_pca56)	:= pca56
> +
> +#Machine depedent values, influenced by gcc capabilitites
> +mach-$(CONFIG_ALPHA_SX164)$(have_mcpu_pca56)	:= pca56
> +mach-$(CONFIG_ALPHA_POLARIS)$(have_mcpu_pca56)	:= pca56
> +mach-$(CONFIG_ALPHA_EV67)$(have_mcpu_ev67)	:= ev67
> +
> +mach-y				:= $(mach-yy)
> +mach-$(CONFIG_ALPHA_GENERIC)	:= ev5
> +mach-$(CONFIG_ALPHA_EV4)	:= ev4
> +mach-$(CONFIG_ALPHA_EV56)	:= ev56
> +mach-$(CONFIG_ALPHA_EV5)	:= ev5
> +mach-$(CONFIG_ALPHA_EV6)	:= ev6

This doesn't work.   For example CONFIG_ALPHA_EV67 depends on
CONFIG_ALPHA_EV6, so we'll never use the -mcpu=ev67 flag.

I'm reverting this part.  I see nothing wrong with an if/else
tree for this.  It's straightforward.  I think anything you come
up with to replace it will be harder to understand at a glance,
and therefore more fragile.


> +# My special boot (msb) writes directly to a specific disk partition,
> +# I doubt most people will want to do that without changes..
> +msb srmboot: vmlinux
> +	$(Q)$(MAKE) -f scripts/Makefile.build obj=$(boot) $@

I've just removed these targets.

I'm testing the rest of the patch now.  Will apply if successful.


r~

      reply	other threads:[~2002-12-31 23:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-30 11:53 [CFT] arch/alpha: Makefiles update Sam Ravnborg
2002-12-31 23:35 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021231153539.A21946@twiddle.net \
    --to=rth@twiddle.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.