From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Trahe, Fiona" <fiona.trahe@intel.com>
Cc: dev@dpdk.org, "De Lara Guarch,
Pablo" <pablo.de.lara.guarch@intel.com>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>
Subject: Re: [PATCH] app/test: Remove hard coding for nb_queue_pairs in test_cryptodev
Date: Thu, 29 Sep 2016 16:25:06 +0200 [thread overview]
Message-ID: <2002488.2H5o8Bgc8G@xps13> (raw)
In-Reply-To: <348A99DA5F5B7549AA880327E580B435890E9364@IRSMSX101.ger.corp.intel.com>
2016-09-29 14:12, Trahe, Fiona:
> > > From: Akhil Goyal <akhil.goyal@nxp.com>
> > >
> > > nb_queue_pairs should not be hard coded with device specific number.
> > > It should be retrieved from the device infos.
> > > Also in ut_setup, ts_params->conf.nb_queue_pairs is already set in
> > > testsuite_setup and we are not modifying it.
> > >
> > > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> >
> > Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> The above code is correct, however it exposes a bug in QAT PMD unit tests.
> And some cleanup needed for unnecessary qp setup code.
> That cleanup then exposed a bug in aesni_mb PMD which prevents re-creating queue pairs of a different size.
>
> I have a fix and cleanup patch ready.
> Just not sure how best to push it?
> The original patch also needs rebasing, doesn't apply cleanly to the latest dpdk-next-crypto
>
> Pablo should I push all as a reply to the first patch - waiting first for that to be rebased?
> Or
> It would save Akhil a rebase and be simpler if I can include the original change in my patch and push all as a v2 superceding the original patch? Is this possible?
> Or
> should I Nack the original patch and push all instead?
My preference goes to a v2.
next prev parent reply other threads:[~2016-09-29 14:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 16:32 [PATCH] examples/ipsec-secgw: Update checksum while decrementing ttl akhil.goyal
2016-09-26 13:28 ` Sergio Gonzalez Monroy
2016-10-05 0:34 ` De Lara Guarch, Pablo
2016-10-05 6:32 ` Akhil Goyal
2016-10-07 20:53 ` De Lara Guarch, Pablo
2016-10-10 12:05 ` Sergio Gonzalez Monroy
2016-10-17 17:05 ` De Lara Guarch, Pablo
2016-10-19 8:38 ` Akhil Goyal
2016-10-26 2:29 ` De Lara Guarch, Pablo
2016-09-26 16:32 ` [PATCH] app/test: Remove hard coding for nb_queue_pairs in test_cryptodev akhil.goyal
2016-09-26 19:36 ` De Lara Guarch, Pablo
2016-09-29 14:12 ` Trahe, Fiona
2016-09-29 14:25 ` Thomas Monjalon [this message]
2016-09-29 14:29 ` De Lara Guarch, Pablo
2016-09-26 16:33 ` [PATCH] test_cryptodev_perf: IV and digest should be stored at a DMAeble address akhil.goyal
2016-10-05 6:40 ` Akhil Goyal
2016-10-05 9:26 ` Kusztal, ArkadiuszX
2016-10-07 11:32 ` Akhil Goyal
2016-10-07 17:06 ` [PATCH v2] " akhil.goyal
2016-10-07 21:36 ` De Lara Guarch, Pablo
2016-10-10 5:22 ` Akhil Goyal
2016-10-10 16:24 ` De Lara Guarch, Pablo
2016-10-12 11:16 ` [PATCH v3] " akhil.goyal
2016-10-12 18:26 ` Trahe, Fiona
2016-10-13 19:35 ` De Lara Guarch, Pablo
2016-09-29 17:18 ` [PATCH v2] app/test: remove hard-coding of crypto num qps Fiona Trahe
2016-10-05 0:49 ` De Lara Guarch, Pablo
2016-10-06 14:55 ` Trahe, Fiona
2016-10-06 17:34 ` [PATCH v3 0/4] remove hard-coding of crypto num qps and cleanup Fiona Trahe
2016-10-07 0:29 ` De Lara Guarch, Pablo
2016-10-07 0:57 ` De Lara Guarch, Pablo
2016-10-06 17:34 ` [PATCH v3 1/4] crypto/aesni_mb: free ring memory on qp release in PMD Fiona Trahe
2016-10-06 17:34 ` [PATCH v3 2/4] app/test: remove pointless for loop Fiona Trahe
2016-10-06 17:34 ` [PATCH v3 3/4] app/test: cleanup unnecessary ring size setup Fiona Trahe
2016-10-06 17:34 ` [PATCH v3 4/4] app/test: remove hard-coding of crypto num qps Fiona Trahe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2002488.2H5o8Bgc8G@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.