From: Tom Rini <trini@kernel.crashing.org>
To: Dan Malek <dan@embeddededge.com>
Cc: Wolfgang Denk <wd@denx.de>, linuxppc-embedded@lists.linuxppc.org
Subject: Re: linuxppc_2_4_devel patch: 8xx FEC extensions
Date: Thu, 2 Jan 2003 11:21:47 -0700 [thread overview]
Message-ID: <20030102182147.GB853@opus.bloom.county> (raw)
In-Reply-To: <3E1480E6.4010802@embeddededge.com>
On Thu, Jan 02, 2003 at 01:11:50PM -0500, Dan Malek wrote:
> Wolfgang Denk wrote:
>
>
> >I don't see where a "volatile" gets dropped in any really significant
> >way.
>
> No, it doesn't. The function logically does exactly the same thing,
> so I don't understand why these changes were necessary. :-)
>
> The original code simply accessed the 'phy_status' in the data structure
> as a volatile object. The modification from Wolfgang makes any data
> structure access volatile, and then updates the 'phy_status' only once
> at the end.
>
> If it makes something work better for Wolfgang, that's fine :-). To me,
> it seems to be covering up some other timing problem since the only
> thing different is how many times a particular memory location is accessed.
Would the patch, along with a comment about this potentially covering up
HW timing issues (since this seems to have 'fixed' a problem on a
certain HW config) be OK with everyone?
--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2003-01-02 18:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-20 1:05 linuxppc_2_4_devel patch: 8xx FEC extensions Wolfgang Denk
2002-12-23 15:12 ` Tom Rini
2002-12-28 0:27 ` Wolfgang Denk
2002-12-30 15:29 ` Tom Rini
2002-12-30 16:26 ` Wolfgang Denk
2002-12-30 18:12 ` Tom Rini
[not found] ` <3E10EF1C.5040505@embeddededge.com>
[not found] ` <20021231155241.GA12063@opus.bloom.county>
[not found] ` <20021231155839.6D6F8C6139@atlas.denx.de>
2002-12-31 16:13 ` Tom Rini
2003-01-02 17:40 ` Wolfgang Denk
[not found] ` <3E1480E6.4010802@embeddededge.com>
2003-01-02 18:21 ` Tom Rini [this message]
[not found] ` <3E1484D9.6070402@embeddededge.com>
2003-01-03 15:47 ` Tom Rini
2003-01-02 17:40 ` Dan Malek
2003-01-03 22:46 ` Paul Mackerras
2003-01-03 23:01 ` Dan Malek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030102182147.GB853@opus.bloom.county \
--to=trini@kernel.crashing.org \
--cc=dan@embeddededge.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.