From: Ralf Baechle <ralf@linux-mips.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Juan Quintela <quintela@mandrakesoft.com>,
mipslist <linux-mips@linux-mips.org>
Subject: Re: [PATCH]: fix possible buffer overflow problem in promlib
Date: Fri, 3 Jan 2003 13:54:23 +0100 [thread overview]
Message-ID: <20030103135422.A7796@linux-mips.org> (raw)
In-Reply-To: <Pine.GSO.4.21.0301022047090.4873-100000@vervain.sonytel.be>; from geert@linux-m68k.org on Thu, Jan 02, 2003 at 08:47:49PM +0100
On Thu, Jan 02, 2003 at 08:47:49PM +0100, Geert Uytterhoeven wrote:
> On 2 Jan 2003, Juan Quintela wrote:
> > as the issue about prom.h is still not clear, please aply the
> > trivial part.
>
> > void prom_printf(char *fmt, ...)
> > {
> > va_list args;
> > - char ppbuf[1024];
> > + char ppbuf[BUFSIZE];
>
> What about making ppbuf static, to reduce stack usage?
By the time when prom_printf() is called stack overflow is not really a
consideration anymore, something fatal has happened before.
prom_printf() is our own variant of early_print() so eventually should
be replaced by that anyway.
Ralf
next prev parent reply other threads:[~2003-01-03 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-02 19:33 [PATCH]: fix possible buffer overflow problem in promlib Juan Quintela
2003-01-02 19:47 ` Geert Uytterhoeven
2003-01-03 12:54 ` Ralf Baechle [this message]
2003-01-03 14:29 ` Thiemo Seufer
2003-01-03 15:48 ` Ralf Baechle
2003-01-03 15:58 ` Thiemo Seufer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030103135422.A7796@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=geert@linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=quintela@mandrakesoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.