From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Hudec Subject: Re: fixing redundant network opens on Linux file creation Date: Tue, 7 Jan 2003 10:35:15 +0100 Sender: samba-technical-admin@lists.samba.org Message-ID: <20030107093515.GF2141@vagabond> References: <20030106221830.GA31419@grulic.org.ar> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Steven French , samba-technical@samba.org, linux-fsdevel@vger.kernel.org Return-path: To: Marcos Dione Content-Disposition: inline In-Reply-To: <20030106221830.GA31419@grulic.org.ar> Errors-To: samba-technical-admin@lists.samba.org List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: List-Id: linux-fsdevel.vger.kernel.org On Mon, Jan 06, 2003 at 07:18:30PM -0300, Marcos Dione wrote: > On Mon, Jan 06, 2003 at 11:25:32AM -0600, Steven French wrote: > > The creat() system call results (for the Linux kernel) in calls to create > > (via vfs_create) then later a call to open (via dentry_open) both of which > > eventually end up (for the cifs vfs) doing a network open of the file from > > the perspective of the CIFS protocol which degrades performance (because > > why not implement create as a separate feature? you can use a > different message and mknod(2) on the server. > > I'm asking 'cause I'll have the same problem when implementing my > thesis. That won't help. You are still doing two upcalls, it still isn't atomic etc. etc. The problem is, that vfs always calls ->create and then ->open, both for open(O_CREAT) and create. ------------------------------------------------------------------------------- Jan 'Bulb' Hudec