[2.5 patch] MODULE_FORCE_UNLOAD must depend on MODULE_UNLOAD

[Adrian Bunk <bunk@fs.tum.de>]

On Wed, Jan 01, 2003 at 02:55:01PM -0500, Robert P. J. Day wrote:

>...
> Loadable module support
>     
>     Does "Module unloading" mean whether or not I can run "rmmod"?
>   And if I deselect this, why can I still select "Forced module
>   unloading"?  Either I can unload or I can't, no?
>...

Thanks for spotting this, after reading kernel/module.c it seems obvious 
to me that you are right. The following simple patch fixes it:

--- linux-2.5.54/init/Kconfig.old	2003-01-08 00:05:12.000000000 +0100
+++ linux-2.5.54/init/Kconfig	2003-01-08 00:05:38.000000000 +0100
@@ -127,7 +127,7 @@
 
 config MODULE_FORCE_UNLOAD
 	bool "Forced module unloading"
-	depends on MODULES && EXPERIMENTAL
+	depends on MODULE_UNLOAD && EXPERIMENTAL
 	help
 	  This option allows you to force a module to unload, even if the
 	  kernel believes it is unsafe: the kernel will remove the module


> rday

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed