All of lore.kernel.org
 help / color / mirror / Atom feed
From: William Lee Irwin III <wli@holomorphy.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org
Subject: Re: [RFC][PATCH] allow bigger PAGE_OFFSET with PAE
Date: Tue, 7 Jan 2003 15:37:13 -0800	[thread overview]
Message-ID: <20030107233713.GB23814@holomorphy.com> (raw)
In-Reply-To: <3E1B334E.8030807@us.ibm.com>

On Tue, Jan 07, 2003 at 12:06:38PM -0800, Dave Hansen wrote:
> Also, this gets the kernel's pagetables right, but neglects 
> userspace's for now.  pgd_alloc() needs to be fixed to allocate 
> another PMD, if the split isn't PMD-alighed.

Um, that should be automatic when USER_PTRS_PER_PGD is increased.

I see the following:

$ grep -n TASK_SIZE include/asm-i386/*.h                 
include/asm-i386/a.out.h:22:#define STACK_TOP   TASK_SIZE
include/asm-i386/elf.h:60:#define ELF_ET_DYN_BASE         (TASK_SIZE / 3 * 2)
include/asm-i386/pgtable.h:68:#define USER_PTRS_PER_PGD (TASK_SIZE/PGDIR_SIZE)
include/asm-i386/processor.h:277:#define TASK_SIZE      (PAGE_OFFSET)
include/asm-i386/processor.h:282:#define TASK_UNMAPPED_BASE     (PAGE_ALIGN(TASK_SIZE / 3))


... which sounds like you need to round up in an overflow-safe fashion
in the macro.


Bill

WARNING: multiple messages have this Message-ID (diff)
From: William Lee Irwin III <wli@holomorphy.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org
Subject: Re: [RFC][PATCH] allow bigger PAGE_OFFSET with PAE
Date: Tue, 7 Jan 2003 15:37:13 -0800	[thread overview]
Message-ID: <20030107233713.GB23814@holomorphy.com> (raw)
In-Reply-To: <3E1B334E.8030807@us.ibm.com>

On Tue, Jan 07, 2003 at 12:06:38PM -0800, Dave Hansen wrote:
> Also, this gets the kernel's pagetables right, but neglects 
> userspace's for now.  pgd_alloc() needs to be fixed to allocate 
> another PMD, if the split isn't PMD-alighed.

Um, that should be automatic when USER_PTRS_PER_PGD is increased.

I see the following:

$ grep -n TASK_SIZE include/asm-i386/*.h                 
include/asm-i386/a.out.h:22:#define STACK_TOP   TASK_SIZE
include/asm-i386/elf.h:60:#define ELF_ET_DYN_BASE         (TASK_SIZE / 3 * 2)
include/asm-i386/pgtable.h:68:#define USER_PTRS_PER_PGD (TASK_SIZE/PGDIR_SIZE)
include/asm-i386/processor.h:277:#define TASK_SIZE      (PAGE_OFFSET)
include/asm-i386/processor.h:282:#define TASK_UNMAPPED_BASE     (PAGE_ALIGN(TASK_SIZE / 3))


... which sounds like you need to round up in an overflow-safe fashion
in the macro.


Bill
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/

  reply	other threads:[~2003-01-07 23:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-07 20:06 [RFC][PATCH] allow bigger PAGE_OFFSET with PAE Dave Hansen
2003-01-07 23:37 ` William Lee Irwin III [this message]
2003-01-07 23:37   ` William Lee Irwin III
2003-01-08 21:04   ` Dave Hansen
2003-01-08 21:04     ` Dave Hansen
2003-01-08 22:05     ` William Lee Irwin III
2003-01-08 22:05       ` William Lee Irwin III
2003-01-08 22:44       ` William Lee Irwin III
2003-01-08 22:44         ` William Lee Irwin III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030107233713.GB23814@holomorphy.com \
    --to=wli@holomorphy.com \
    --cc=haveblue@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.