All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Simon Scheiwiller <simon@hornweb.ch>
Cc: linux-kernel@vger.kernel.org
Subject: Re: kobject.h makes lilo compile break
Date: Tue, 7 Jan 2003 21:32:40 -0800	[thread overview]
Message-ID: <20030108053240.GB32422@kroah.com> (raw)
In-Reply-To: <005f01c2b3f6$b66ba5b0$0400a8c0@gwaihir>

On Sat, Jan 04, 2003 at 02:39:31PM +0100, Simon Scheiwiller wrote:
> Hello
> 
> When I'm compiling lilo on a machine with kernel 2.5.54, I get the following
> error:
> 
> 
> gcc -c -O2 -Wall -g `( if [ -r $ROOT/etc/lilo.defines ]; then cat
> $ROOT/etc/lilo.defines; else
> echo -DBDATA -DBUILTIN -DDSECS=3 -DIGNORECASE -DLBA32 -DLVM -DEVMS -DM386 -D
> ONE_SHOT -DPASS160 -DREISERFS -DREWRITE_TABLE -DSOLO_CHAIN -DVARSETUP -DVERS
> ION -DUNIFY; fi ) | sed 's/-D/-DLFC_/g'` `[ -r /usr/include/asm/boot.h ] &&
> echo -DHAS_BOOT_H` `cat mylilo.h` lilo.c
> In file included from /usr/include/linux/kobject.h:10,
>                  from /usr/include/linux/device.h:28,
>                  from /usr/include/linux/genhd.h:15,
>                  from common.h:20,
>                  from lilo.c:25:
> /usr/include/linux/list.h:323:2: warning: #warning "don't include kernel
> headers in userspace"

Um, why not heed this warning?  :)

And yes, it looks like Pat got a change in to prevent kobject.h from
being included if __KERNEL__ is not set, but this is not the proper fix.
See the archives for the many discussions about not including kernel
header files in userspace programs.

thanks,

greg k-h

      reply	other threads:[~2003-01-08  5:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-04 13:39 kobject.h makes lilo compile break Simon Scheiwiller
2003-01-08  5:32 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030108053240.GB32422@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simon@hornweb.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.