All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Thornber <joe@fib011235813.fsnet.co.uk>
To: Joe Thornber <joe@fib011235813.fsnet.co.uk>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	Linux Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/10] dm: Don't let the ioctl interface drop a suspended device
Date: Wed, 8 Jan 2003 09:54:10 +0000	[thread overview]
Message-ID: <20030108095410.GB2063@reti> (raw)
In-Reply-To: <20030108095221.GA2063@reti>

Don't let the ioctl interface drop a suspended device.
--- diff/drivers/md/dm-ioctl.c	2002-12-30 10:17:13.000000000 +0000
+++ source/drivers/md/dm-ioctl.c	2003-01-02 11:10:14.000000000 +0000
@@ -812,6 +812,24 @@
 		return -EINVAL;
 	}
 
+	/*
+	 * You may ask the interface to drop its reference to an
+	 * in use device.  This is no different to unlinking a
+	 * file that someone still has open.  The device will not
+	 * actually be destroyed until the last opener closes it.
+	 * The name and uuid of the device (both are interface
+	 * properties) will be available for reuse immediately.
+	 *
+	 * You don't want to drop a _suspended_ device from the
+	 * interface, since that will leave you with no way of
+	 * resuming it.
+	 */
+	if (dm_suspended(hc->md)) {
+		DMWARN("refusing to remove a suspended device.");
+		up_write(&_hash_lock);
+		return -EPERM;
+	}
+
 	__hash_remove(hc);
 	up_write(&_hash_lock);
 	return 0;

  reply	other threads:[~2003-01-08  9:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-08  9:52 device-mapper patchset 2.5.54-dm-1 Joe Thornber
2003-01-08  9:54 ` Joe Thornber [this message]
2003-01-08  9:54 ` [PATCH 2/10] dm: Correct clone info initialisation Joe Thornber
2003-01-08  9:55 ` [PATCH 3/10] dm: Correct target_type reference counting Joe Thornber
2003-01-08  9:56 ` [PATCH 4/10] dm: rwlock_t -> rw_semaphore (fluff) Joe Thornber
2003-01-08  9:57 ` [PATCH 5/10] dm: Call dm_put_target_type() *after* calling the destructor Joe Thornber
2003-01-08  9:57 ` [PATCH 6/10] dm: Remove explicit returns from void fns (fluff) Joe Thornber
2003-01-08  9:58 ` [PATCH 7/10] dm: printk tgt->error if dm_table_add_target() fails Joe Thornber
2003-01-08  9:59 ` [PATCH 8/10] dm: Simplify error->map Joe Thornber
2003-01-08  9:59 ` [PATCH 9/10] dm: Export dm_table_get_mode() Joe Thornber
2003-01-08 10:00 ` [PATCH 10/10] dm: Remove redundant error checking Joe Thornber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030108095410.GB2063@reti \
    --to=joe@fib011235813.fsnet.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.