From: Rusty Russell <rusty@rustcorp.com.au>
To: Muli Ben-Yehuda <mulix@mulix.org>
Cc: Linux-Kernel <linux-kernel@vger.kernel.org>, torvalds@transmeta.com
Subject: Re: PATCH: module_text_address() defined but not used in module.h
Date: Wed, 08 Jan 2003 23:01:48 +1100 [thread overview]
Message-ID: <20030110073329.185902C506@lists.samba.org> (raw)
In-Reply-To: Your message of "Tue, 07 Jan 2003 15:12:43 +0200." <20030107131243.GJ25540@alhambra>
In message <20030107131243.GJ25540@alhambra> you write:
> module_text_address() is defined as 'static int ...' if modules are
> not configured in in module.h, leading to a compiler warning that it
> is defined but not used. Make it static inline. Patch against
> 2.5.54-bk.
Linus, please apply. Obviously correct, my mistake.
From: Muli Ben-Yehuda <mulix@mulix.org>
diff -Nru a/include/linux/module.h b/include/linux/module.h
--- a/include/linux/module.h Tue Jan 7 14:18:37 2003
+++ b/include/linux/module.h Tue Jan 7 14:18:37 2003
@@ -328,7 +328,7 @@
}
/* Is this address in a module? */
-static int module_text_address(unsigned long addr)
+static inline int module_text_address(unsigned long addr)
{
return 0;
}
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
prev parent reply other threads:[~2003-01-10 7:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-07 13:12 PATCH: module_text_address() defined but not used in module.h Muli Ben-Yehuda
2003-01-08 12:01 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030110073329.185902C506@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mulix@mulix.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.