From: Rusty Russell <rusty@rustcorp.com.au>
To: Richard Henderson <rth@twiddle.net>
Cc: Miles Bader <miles@gnu.org>,
linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [PATCH] Make `obsolete params' work correctly if MODULE_SYMBOL_PREFIX is non-empty
Date: Fri, 10 Jan 2003 21:20:31 +1100 [thread overview]
Message-ID: <20030110102144.4BE3C2C113@lists.samba.org> (raw)
In-Reply-To: Your message of "Fri, 10 Jan 2003 01:52:03 -0800." <20030110015203.A16268@twiddle.net>
In message <20030110015203.A16268@twiddle.net> you write:
> On Wed, Jan 08, 2003 at 10:56:51PM +1100, Rusty Russell wrote:
> > + char sym_name[strlen(obsparm[i].name) + 2];
>
> Are you really intending to use variable sized allocation
> on the kernel stack?
Yep. Maximum length of obsolete parameter name in current kernel:
seq_default_timer_resolution (28 chars).
It's far more likely that someone will hit the unchecked kmalloc
allocations in arch/alpha/kernel/modules.c 8)
Hope that helps,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2003-01-10 10:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-07 6:32 [PATCH] Make `obsolete params' work correctly if MODULE_SYMBOL_PREFIX is non-empty Miles Bader
2003-01-08 11:56 ` Rusty Russell
2003-01-10 7:39 ` Miles Bader
2003-01-11 14:50 ` Bill Davidsen
2003-01-10 9:52 ` Richard Henderson
2003-01-10 10:20 ` Rusty Russell [this message]
2003-01-10 17:03 ` Linus Torvalds
2003-01-11 4:20 ` Rusty Russell
2003-01-11 5:36 ` Linus Torvalds
2003-01-11 13:42 ` Rusty Russell
2003-01-10 10:39 ` Miles Bader
-- strict thread matches above, loose matches on Subject: below --
2003-01-09 9:49 Miles Bader
2003-01-10 8:31 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030110102144.4BE3C2C113@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=miles@gnu.org \
--cc=rth@twiddle.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.