Re: RME96 driver patch

[Martin Langer <martin-langer@gmx.de>]

On Sun, Jan 05, 2003 at 04:46:47PM +0100, Anders Torger wrote:
> 
> Here is a patch against rme96.c
> 

snd_rme96_capture_spdif_open(snd_pcm_substream_t *substream)

[...]

+       runtime->hw = snd_rme96_capture_spdif_info;
+        if ((rate = snd_rme96_capture_getrate(rme96, &isadat)) > 0) {
+                if (isadat) {
+                        return -EIO;
+                }
+                runtime->hw.rates = snd_rme96_ratecode(rate);
+                runtime->hw.rate_min = rate;
+                runtime->hw.rate_max = rate;
+        }


You were changing sample rates in snd_rme96_capture_spdif_open. Isn't it too
late there? Looks like capturing with wrong sample rates is now possible?
Wouldn't this be better placed in the snd_rme96_capture_hw_params?


martin


-- 
"2b|!2b"


-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com