From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.gmx.net (mail.gmx.net [213.165.65.60]) by dsl2.external.hp.com (Postfix) with SMTP id A66344829 for ; Sun, 12 Jan 2003 05:35:57 -0700 (MST) From: Helge Deller To: Geert Uytterhoeven Date: Sun, 12 Jan 2003 13:35:33 +0100 Cc: Alan Cox , parisc-linux@parisc-linux.org, Linux/PPC Development , Linux/m68k References: In-Reply-To: MIME-Version: 1.0 Message-Id: <200301121333.17077.deller@gmx.de> Content-Type: Multipart/Mixed; boundary="Boundary-00=_VEWI+gdsC5OAG5n" Subject: [parisc-linux] Re: Generic RTC driver in 2.4.x Sender: parisc-linux-admin@lists.parisc-linux.org Errors-To: parisc-linux-admin@lists.parisc-linux.org List-Help: List-Post: List-Subscribe: , List-Id: parisc-linux developers list List-Unsubscribe: , List-Archive: --Boundary-00=_VEWI+gdsC5OAG5n Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Sunday 12 January 2003 12:33, Geert Uytterhoeven wrote: > I made some more changes afterwards: > - Add forward declaration for gen_rtc_interrupt() This one should be moved inside the #ifdef CONFIG_GEN_RTC_X section to avoid "genrtc.c:69: warning: `gen_rtc_interrupt' declared `static' but never defined" warnings. Please see attached patch. Or, you could just move the declaration of gen_rtc_interrupt() above the one from genrtc_troutine(), in which case we wouldn't need the forward declaration at all. > BTW, perhaps we should move the global RTC_* definitions in to > , or merge them with the ones in and > move them to ? IMHO leaving them architecture specific in seems best to me, and it leaves the most possibilities to make them later more dependend on the hardware. Helge --Boundary-00=_VEWI+gdsC5OAG5n Content-Type: text/plain; charset="iso-8859-1"; name="diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff" --- ./genrtc.c.geert Sun Jan 12 13:16:40 2003 +++ ./genrtc.c Sun Jan 12 13:15:18 2003 @@ -66,9 +66,6 @@ static DECLARE_WAIT_QUEUE_HEAD(gen_rtc_wait); -static void gen_rtc_interrupt(unsigned long arg); - - /* * Bits in gen_rtc_status. */ @@ -99,6 +96,8 @@ static int stop_rtc_timers; /* don't requeue tasks */ static spinlock_t gen_rtc_lock = SPIN_LOCK_UNLOCKED; +static void gen_rtc_interrupt(unsigned long arg); + /* * Routine to poll RTC seconds field for change as often as posible, * after first RTC_UIE use timer to reduce polling --Boundary-00=_VEWI+gdsC5OAG5n-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Helge Deller To: Geert Uytterhoeven Subject: Re: Generic RTC driver in 2.4.x Date: Sun, 12 Jan 2003 13:35:33 +0100 Cc: Alan Cox , parisc-linux@parisc-linux.org, Linux/PPC Development , Linux/m68k References: In-Reply-To: MIME-Version: 1.0 Message-Id: <200301121333.17077.deller@gmx.de> Content-Type: Multipart/Mixed; boundary="Boundary-00=_VEWI+gdsC5OAG5n" Sender: owner-linuxppc-dev@lists.linuxppc.org List-Id: --Boundary-00=_VEWI+gdsC5OAG5n Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Sunday 12 January 2003 12:33, Geert Uytterhoeven wrote: > I made some more changes afterwards: > - Add forward declaration for gen_rtc_interrupt() This one should be moved inside the #ifdef CONFIG_GEN_RTC_X section to avoid "genrtc.c:69: warning: `gen_rtc_interrupt' declared `static' but never defined" warnings. Please see attached patch. Or, you could just move the declaration of gen_rtc_interrupt() above the one from genrtc_troutine(), in which case we wouldn't need the forward declaration at all. > BTW, perhaps we should move the global RTC_* definitions in to > , or merge them with the ones in and > move them to ? IMHO leaving them architecture specific in seems best to me, and it leaves the most possibilities to make them later more dependend on the hardware. Helge --Boundary-00=_VEWI+gdsC5OAG5n Content-Type: text/plain; charset="iso-8859-1"; name="diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff" --- ./genrtc.c.geert Sun Jan 12 13:16:40 2003 +++ ./genrtc.c Sun Jan 12 13:15:18 2003 @@ -66,9 +66,6 @@ static DECLARE_WAIT_QUEUE_HEAD(gen_rtc_wait); -static void gen_rtc_interrupt(unsigned long arg); - - /* * Bits in gen_rtc_status. */ @@ -99,6 +96,8 @@ static int stop_rtc_timers; /* don't requeue tasks */ static spinlock_t gen_rtc_lock = SPIN_LOCK_UNLOCKED; +static void gen_rtc_interrupt(unsigned long arg); + /* * Routine to poll RTC seconds field for change as often as posible, * after first RTC_UIE use timer to reduce polling --Boundary-00=_VEWI+gdsC5OAG5n-- ** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/