From: Oleg Drokin <green@namesys.com>
To: Chris Mason <mason@suse.com>
Cc: linux-kernel@vger.kernel.org, eazgwmir@umail.furryterror.org,
viro@math.psu.edu, nikita@namesys.com
Subject: Re: [2.4] VFS locking problem during concurrent link/unlink
Date: Thu, 16 Jan 2003 19:07:22 +0300 [thread overview]
Message-ID: <20030116190722.A4646@namesys.com> (raw)
In-Reply-To: <1042732927.31100.2205.camel@tiny.suse.com>
Hello!
On Thu, Jan 16, 2003 at 11:02:08AM -0500, Chris Mason wrote:
> > Yes we do.
> > But on the other hand I've put a check at the beginning of reiserfs_link
> > and I am still seeing these links on inodes with i_nlink == 0.
> That's because we don't inc the link count in reiserfs_link before we
> schedule. The bug works a little like this:
> link count at 1
> reiserfs_link: make new directory entry for link, schedule()
> reiserfs_unlink: dec link count to zero, remove file stat data
> reiserfs_link: inc link count, return thinking the stat data is still
> there
That was my original yesterday's assumption.
But debug prints I put in place did not confirmed it.
Also if we are having a dentry pinned in memory (by sys_link), inode should not
be deleted, so the statdata should stay inplace as Nikita argues.
Bye,
Oleg
prev parent reply other threads:[~2003-01-16 15:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-16 11:00 [2.4] VFS locking problem during concurrent link/unlink Oleg Drokin
2003-01-16 15:39 ` Chris Mason
2003-01-16 15:43 ` Oleg Drokin
2003-01-16 16:02 ` Chris Mason
2003-01-16 16:06 ` Nikita Danilov
2003-01-16 16:22 ` Chris Mason
2003-01-16 17:03 ` Oleg Drokin
2003-01-16 17:20 ` Oleg Drokin
2003-01-16 16:07 ` Oleg Drokin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030116190722.A4646@namesys.com \
--to=green@namesys.com \
--cc=eazgwmir@umail.furryterror.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@suse.com \
--cc=nikita@namesys.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.