All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Dave Jones <davej@codemonkey.org.uk>,
	linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Cc: alan@redhat.com, akpm@digeo.com
Subject: cs89x0 in 2.5 (was Re: eepro100 - 802.1q - mtu size)
Date: Fri, 17 Jan 2003 12:49:28 -0500	[thread overview]
Message-ID: <20030117174928.GA8304@gtf.org> (raw)
In-Reply-To: <20030117172719.GA31343@codemonkey.org.uk>

On Fri, Jan 17, 2003 at 05:27:19PM +0000, Dave Jones wrote:
> On Fri, Jan 17, 2003 at 11:28:18AM -0500, Jeff Garzik wrote:
> 
>  > The reason why the patch was not accepted is that it changes one magic
>  > number to another magic number, and without chipset docs, I had no idea
>  > what either magic number really meant.
> 
> Whilst on the subject of magic numbers in net drivers, did we ever get
> to the bottom of 2.4's ChangeSet 1.587.9.20 
> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/davej/patches/2.5/2.5.48/split-dj1/net-cs89x0-media-corrections.diff


IIRC it came from -ac tree without explanation, and I think akpm said it
broke stuff.  Since it has an alive maintainer (akpm), I would rather
let Alan and Andrew fight it out :)  Whatever they decide is fine with
me for 2.5.

	Jeff




  reply	other threads:[~2003-01-17 17:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-17 14:53 eepro100 - 802.1q - mtu size Florian Lohoff
2003-01-17 16:08 ` Paul P Komkoff Jr
2003-01-17 16:28   ` Jeff Garzik
2003-01-17 17:27     ` Dave Jones
2003-01-17 17:49       ` Jeff Garzik [this message]
2003-01-17 20:14         ` cs89x0 in 2.5 (was Re: eepro100 - 802.1q - mtu size) Paul P Komkoff Jr
2003-01-21  2:17         ` Alan
2003-01-21 23:39           ` Jeff Garzik
2003-01-17 17:48     ` eepro100 - 802.1q - mtu size Ducrot Bruno
2003-01-17 19:25     ` Florian Lohoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030117174928.GA8304@gtf.org \
    --to=jgarzik@pobox.com \
    --cc=akpm@digeo.com \
    --cc=alan@redhat.com \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.