All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: john stultz <johnstul@us.ibm.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][RESEND] linux-2.5.58_timer-tsc-cleanup_A0
Date: Sat, 18 Jan 2003 12:48:14 +1100	[thread overview]
Message-ID: <20030118025509.C295F2C0D0@lists.samba.org> (raw)
In-Reply-To: Your message of "15 Jan 2003 16:15:14 -0800." <1042676113.1515.129.camel@w-jstultz2.beaverton.ibm.com>

In message <1042676113.1515.129.camel@w-jstultz2.beaverton.ibm.com> you write:
> Linus, All,
> 	This patch cleans up the timer_tsc code, removing the unused use_tsc
> variable and making fast_gettimeoffset_quotient static.

But use_tsc is still used:

static int
time_cpufreq_notifier(struct notifier_block *nb, unsigned long val,
		       void *data)
{

....

#ifndef CONFIG_SMP
		if (use_tsc) {
			fast_gettimeoffset_quotient = cpufreq_scale(fast_gettimeoffset_ref, freq->new, ref_freq);
			cpu_khz = cpufreq_scale(cpu_khz_ref, ref_freq, freq->new);
		}
#endif


And almost any patch to the x86 boot code is too convoluted to be
"trivial" IMHO.

Sorry,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

  reply	other threads:[~2003-01-18  2:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-16  0:15 [PATCH][RESEND] linux-2.5.58_timer-tsc-cleanup_A0 john stultz
2003-01-18  1:48 ` Rusty Russell [this message]
2003-01-18  3:02   ` john stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030118025509.C295F2C0D0@lists.samba.org \
    --to=rusty@rustcorp.com.au \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.