From: Anton Blanchard <anton@samba.org>
To: Andrew Morton <akpm@digeo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: recent change to exit_mmap
Date: Sat, 18 Jan 2003 18:23:31 +1100 [thread overview]
Message-ID: <20030118072331.GF7800@krispykreme> (raw)
In-Reply-To: <20030117230014.2647791a.akpm@digeo.com>
> On seconds thoughts...
>
> Are the first two SET_PERSONALITY() calls in there actually doing anything?
> Perhaps you're right, and we only need the one at line 615, whcih is in the
> right place?
Sounds good. The following patch tests out OK.
Anton
===== fs/binfmt_elf.c 1.34 vs edited =====
--- 1.34/fs/binfmt_elf.c Mon Nov 25 19:59:02 2002
+++ edited/fs/binfmt_elf.c Sat Jan 18 18:16:52 2003
@@ -536,8 +536,6 @@
strcmp(elf_interpreter,"/usr/lib/ld.so.1") == 0)
ibcs2_interpreter = 1;
- SET_PERSONALITY(elf_ex, ibcs2_interpreter);
-
interpreter = open_exec(elf_interpreter);
retval = PTR_ERR(interpreter);
if (IS_ERR(interpreter))
@@ -578,9 +576,6 @@
// printk(KERN_WARNING "ELF: Ambiguous type, using ELF\n");
interpreter_type = INTERPRETER_ELF;
}
- } else {
- /* Executables without an interpreter also need a personality */
- SET_PERSONALITY(elf_ex, ibcs2_interpreter);
}
/* OK, we are done with that, now set up the arg stuff,
next prev parent reply other threads:[~2003-01-18 7:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-18 6:05 recent change to exit_mmap Anton Blanchard
2003-01-18 6:44 ` Andrew Morton
2003-01-18 7:42 ` David Mosberger
2003-01-18 7:53 ` Andrew Morton
2003-01-18 7:58 ` David Mosberger
2003-01-18 8:15 ` Andrew Morton
2003-01-18 8:15 ` David Mosberger
2003-01-18 7:00 ` Andrew Morton
2003-01-18 7:23 ` Anton Blanchard [this message]
2003-01-18 10:44 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030118072331.GF7800@krispykreme \
--to=anton@samba.org \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.