From: Joel Becker <Joel.Becker@oracle.com>
To: Christoph Hellwig <hch@infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@digeo.com>,
Linus Torvalds <torvalds@transmeta.com>,
Wim Coekaerts <Wim.Coekaerts@oracle.com>
Subject: Re: [PATCH][2.5] hangcheck-timer
Date: Tue, 21 Jan 2003 09:33:04 -0800 [thread overview]
Message-ID: <20030121173303.GU20972@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20030121081158.A21080@infradead.org>
On Tue, Jan 21, 2003 at 08:11:58AM +0000, Christoph Hellwig wrote:
> I can't your see the driver reference CONFIG_* directly anywhere.
I don't, but I swear something needed it somewhere. I'll look into
removing it.
> > +static int hangcheck_tick = DEFAULT_IOFENCE_TICK;
> > +static int hangcheck_margin = DEFAULT_IOFENCE_MARGIN;
> > +static int hangcheck_reboot = 0; /* Do not reboot */
>
> no need to initialize static variables to zero, they'll just go into .bss.
No need, but it is good to explicity mention that the default is
not to reboot.
> It might be worth using Rusty's new module paramters for new code submitted
> to 2.5 instead of the legacy interfaces.
I guess I should. I'm still encountering the fact that the
module loader in 2.5.59 has issues.
> #if DEBUG maybe? or VERBOSE?
Probably just to remove. Missed it.
Joel
--
One look at the From:
understanding has blossomed
.procmailrc grows
- Alexander Viro
Joel Becker
Senior Member of Technical Staff
Oracle Corporation
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2003-01-21 17:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-21 1:19 [PATCH][2.5] hangcheck-timer Joel Becker
2003-01-21 8:11 ` Christoph Hellwig
2003-01-21 17:33 ` Joel Becker [this message]
2003-01-21 18:44 ` [PATCH (take 2)][2.5] hangcheck-timer Joel Becker
2003-01-21 18:59 ` Christoph Hellwig
2003-01-21 19:48 ` Joel Becker
2003-01-21 19:56 ` Christoph Hellwig
2003-01-21 19:04 ` Sam Ravnborg
2003-01-21 12:50 ` [PATCH][2.5] hangcheck-timer Dave Jones
2003-01-21 17:40 ` Joel Becker
2003-01-21 17:42 ` Dave Jones
2003-01-21 18:42 ` Joel Becker
[not found] <200301210135.h0L1ZFa06867@eng2.beaverton.ibm.com>
2003-01-21 1:42 ` john stultz
2003-01-21 2:00 ` Joel Becker
2003-01-21 2:45 ` john stultz
2003-01-21 17:29 ` Joel Becker
2003-01-21 20:03 ` john stultz
2003-01-21 20:30 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030121173303.GU20972@ca-server1.us.oracle.com \
--to=joel.becker@oracle.com \
--cc=Wim.Coekaerts@oracle.com \
--cc=akpm@digeo.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.