All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Gregoire Favre <greg@ulima.unil.ch>,
	Joerg Schilling <schilling@fokus.fraunhofer.de>
Cc: cdwrite@other.debian.org, linux-kernel@vger.kernel.org
Subject: Re: Can't burn DVD under 2.5.59 with ide-cd
Date: Thu, 23 Jan 2003 19:10:02 +0100	[thread overview]
Message-ID: <20030123181002.GV910@suse.de> (raw)
In-Reply-To: <20030123180653.GU910@suse.de>

On Thu, Jan 23 2003, Jens Axboe wrote:
> On Thu, Jan 23 2003, Gregoire Favre wrote:
> > On Thu, Jan 23, 2003 at 06:52:24PM +0100, Joerg Schilling wrote:
> > 
> > > In one of my mails, I decribed why there are 2 bugs in the kernel.
> > > Only one of them so far has been fixed. The sense data is still missing.
> > 
> > Oups, sorry I didn't read enough carefully!!!
> > 
> > Does someone know how to fix the sense data bug?
> 
> In drivers/ide/ide-cd.c:cdrom_end_request(), try to insert something
> ala:
> 
> 	if ((rq->flags & REQ_SENSE) && uptodate) {
>                 struct request *failed = (struct request *) rq->buffer;
>                 struct cdrom_info *info = drive->driver_data;
>                 void *sense = &info->sense_data;
> 
> +		if (failed && block_pc_request(failed))
> +			printk("%s: failed %p\n", __FUNCTION__, failed->sense);
> 
>                 if (failed && failed->sense)
>                         sense = failed->sense;
> 
>                 cdrom_analyze_sense_data(drive, failed, sense);
> 	}
> 
> in pseudo-patch form.

oh, and dump failed->sense_len as well!

-- 
Jens Axboe


  reply	other threads:[~2003-01-23 18:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-23 17:52 Can't burn DVD under 2.5.59 with ide-cd Joerg Schilling
2003-01-23 18:01 ` Gregoire Favre
2003-01-23 18:06   ` Jens Axboe
2003-01-23 18:10     ` Jens Axboe [this message]
2003-01-23 18:55       ` Gregoire Favre
2003-01-23 19:07         ` Jens Axboe
2003-01-23 19:21           ` Gregoire Favre
2003-01-23 21:18             ` Jens Axboe
2003-01-23 21:54               ` Gregoire Favre
2003-01-24  7:55                 ` Jens Axboe
2003-01-24  9:10     ` Henning P. Schmiedehausen
2003-01-24  9:26       ` Jens Axboe
2003-01-25 14:25         ` Gregoire Favre
2003-01-26 16:23           ` Jens Axboe
2003-01-26 16:38             ` Gregoire Favre
2003-01-23 18:02 ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2003-01-22 15:38 Joerg Schilling
2003-01-22  8:23 Joerg Schilling
2003-01-22  8:35 ` Jens Axboe
2003-01-22  9:47   ` Gregoire Favre
2003-01-22 12:57   ` Bob_Tracy(0000)
2003-01-23 17:51   ` Gregoire Favre
2003-01-22 12:00 ` Andre Hedrick
2003-01-22 18:13 ` William Lee Irwin III
2003-01-22  1:09 Joerg Schilling
2003-01-22  8:05 ` Jens Axboe
2003-01-21 22:07 Gregoire Favre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030123181002.GV910@suse.de \
    --to=axboe@suse.de \
    --cc=cdwrite@other.debian.org \
    --cc=greg@ulima.unil.ch \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schilling@fokus.fraunhofer.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.