From: Jens Axboe <axboe@suse.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IDE: Do not call bh_phys() on buffers with invalid b_page.
Date: Wed, 29 Jan 2003 16:47:06 +0100 [thread overview]
Message-ID: <20030129154706.GG31566@suse.de> (raw)
In-Reply-To: <1043855055.536.81.camel@zion.wanadoo.fr>
On Wed, Jan 29 2003, Benjamin Herrenschmidt wrote:
> On Wed, 2003-01-29 at 16:38, Jens Axboe wrote:
> > No, any b_data < PAGE_OFFSET is not wrong, that's the point. For highmem
> > b_page, b_data will be the offset into the page. So it could be 2048,
> > for instance.
>
> In the other if() case, yes ;)
b_data < PAGE_SIZE would not be a bug in the other case, if
PageHighmem(bh->b_page). If !PageHighmem(bh->b_page), then b_data <
PAGE_OFFSET would be a bug, yes.
But lets drop this now, it's getting way silly! :)
> All I wanted to spot is that < PAGE_OFFSET would catch the PAGE_SIZE bug
> as well ;) But that's not a problem in real life anyway it seems.
That is correct, but as I said it's nice to separate them because it's
two bugs really. And the one I wanted to catch was number 1, and that's
the one I put in. EOD?
--
Jens Axboe
prev parent reply other threads:[~2003-01-29 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-29 14:57 [PATCH] IDE: Do not call bh_phys() on buffers with invalid b_page Benjamin Herrenschmidt
2003-01-29 15:00 ` Jens Axboe
2003-01-29 15:20 ` Benjamin Herrenschmidt
2003-01-29 15:22 ` Jens Axboe
2003-01-29 15:26 ` Benjamin Herrenschmidt
2003-01-29 15:38 ` Jens Axboe
2003-01-29 15:44 ` Benjamin Herrenschmidt
2003-01-29 15:47 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030129154706.GG31566@suse.de \
--to=axboe@suse.de \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.