From: Vojtech Pavlik <vojtech@suse.cz>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Dave Jones <davej@codemonkey.org.uk>,
Tomas Szepe <szepe@pinerecords.com>,
lkml <linux-kernel@vger.kernel.org>,
Andrew Rodland <arodland@noln.com>,
john@grabjohn.com
Subject: Re: [PATCH] 2.5.59 morse code panics
Date: Fri, 31 Jan 2003 18:59:27 +0100 [thread overview]
Message-ID: <20030131185927.B25927@ucw.cz> (raw)
In-Reply-To: <1043952334.31674.20.camel@irongate.swansea.linux.org.uk>; from alan@lxorguk.ukuu.org.uk on Thu, Jan 30, 2003 at 06:45:34PM +0000
On Thu, Jan 30, 2003 at 06:45:34PM +0000, Alan Cox wrote:
> On Thu, 2003-01-30 at 17:36, Dave Jones wrote:
> > As this patch further builds upon the previous one,
> > It'd take a complete change of mind on his part to take
> > this as it is.
>
> If its attached to atkbd then its not a PCism and its now
> nicely modularised in the atkbd driver. Providing we have
> a clear split between the core "morse sender" and the
> platform specific morse output device (do we want
> morse_ops 8)) it should be clean and you can write morse
> drivers for pc speaker, for non pc keyboard and even for
> soundblaster 8)
It should be in the keyboard.c file, using input_event() to blink the
LEDs. This way it'll work on all archs in 2.5.
I will not accept it as a patch for atkbd.c, unless there is a strong
reason to do it there.
--
Vojtech Pavlik
SuSE Labs
next prev parent reply other threads:[~2003-01-31 17:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-30 15:07 [PATCH] 2.5.59 morse code panics Tomas Szepe
2003-01-30 17:36 ` Dave Jones
2003-01-30 18:45 ` Alan Cox
2003-01-31 10:43 ` Tomas Szepe
2003-01-31 11:12 ` John Bradford
2003-01-31 13:22 ` Dave Jones
2003-01-31 14:40 ` Valdis.Kletnieks
2003-01-31 14:58 ` John Bradford
2003-01-31 15:05 ` Dave Jones
2003-01-31 15:32 ` Valdis.Kletnieks
2003-01-31 15:09 ` Alan Cox
2003-01-31 14:29 ` John Bradford
2003-01-31 15:13 ` Dave Jones
2003-01-31 15:12 ` Dave Jones
2003-01-31 15:27 ` John Bradford
2003-01-31 15:21 ` Scott Robert Ladd
2003-01-31 17:59 ` Vojtech Pavlik [this message]
2003-01-31 18:06 ` Tomas Szepe
2003-01-31 19:38 ` Tomas Szepe
[not found] <20030131104326.GF12286@louise.pinerecords.com.suse.lists.linux.kernel>
[not found] ` <200301311112.h0VBCv00000575@darkstar.example.net.suse.lists.linux.kernel>
[not found] ` <20030131132221.GA12834@codemonkey.org.uk.suse.lists.linux.kernel>
[not found] ` <1044025785.1654.13.camel@irongate.swansea.linux.org.uk.suse.lists.linux.kernel>
2003-01-31 15:34 ` Andi Kleen
2003-01-31 15:41 ` Tomas Szepe
2003-01-31 16:01 ` John Bradford
2003-01-31 16:11 ` Tomas Szepe
2003-01-31 16:17 ` John Bradford
2003-01-31 19:52 ` Horst von Brand
2003-01-31 20:04 ` John Bradford
2003-01-31 21:08 ` Eric Weigle
2003-01-31 21:14 ` John Bradford
2003-02-02 15:42 ` Bill Davidsen
2003-02-03 19:14 ` Jos Hulzink
2003-02-03 21:29 ` Bill Davidsen
2003-02-04 6:00 ` Peter C. Norton
2003-02-07 15:51 ` Ryan Anderson
2003-02-07 16:39 ` John Bradford
2003-01-31 15:46 ` Dave Jones
2003-01-31 15:55 ` Valdis.Kletnieks
2003-02-03 15:50 ` Pavel Machek
2003-02-04 16:32 ` Henning P. Schmiedehausen
-- strict thread matches above, loose matches on Subject: below --
2003-01-31 21:31 Albert D. Cahalan
2003-02-05 17:56 Marcelo Roberto Jimenez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030131185927.B25927@ucw.cz \
--to=vojtech@suse.cz \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arodland@noln.com \
--cc=davej@codemonkey.org.uk \
--cc=john@grabjohn.com \
--cc=linux-kernel@vger.kernel.org \
--cc=szepe@pinerecords.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.