Re: [RFC][PATCH] new modversions implementation

[Rusty Russell <rusty@rustcorp.com.au>]

In message <Pine.LNX.4.21.0302021616230.11976-100000@mussel> you write:
> +#ifdef CONFIG_MODVERSIONING
> +       if ((mod->symbols.num_syms && !crcindex)
> +           || (mod->gpl_symbols.num_syms && !gplcrcindex)) {

Thanks Paul!  Good catch.

Kai is currently the one beating this patch into shape: he's the
Makefile guru, I just twiddle with modules.  I'm waiting for him and
Andrew Morton to merge with Linus to see what's left to apply.

> Also, whatever happened to modversions.h? A module I have refuses to
> compile without it. I'm not yet such a good hacker to figure out how your
> new modversions implementation works 8) 

You shouldn't need modversions.h any more: you can simply excise it.
This means that such a module will taint a modversioned kernel,
though.

The correct (and future-proof) way to build external modules is to use
the kernel makefiles themselves:

http://hypermail.idiosynkrasia.net/linux-kernel/archived/2002/week23/0162.html

Hope that helps!
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.